Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added carousel functionality to week-only format #14

Merged
merged 3 commits into from
Nov 16, 2018
Merged

Added carousel functionality to week-only format #14

merged 3 commits into from
Nov 16, 2018

Conversation

lucasvienna
Copy link
Member

I used the same existing implementation and merged most of the code necessary to handle both the monthly and weekly view. I managed to removed a lot of duplicate code doing this, but I believe the builder methods can also be merged in a future version.

@hyochan
Copy link
Member

hyochan commented Nov 15, 2018

Thanks. It really looks great. But when changing weekFormat from hot reloading it throws error like below because the widget wasn't constructed.
image

I think both should be constructed to prevent throw. What do you think?

@lucasvienna
Copy link
Member Author

Oh, I see what you mean. Yeah, that might cause problems when switching modes during runtime. I will push an update tomorrow with a fix.

@lucasvienna
Copy link
Member Author

Fix pushed, you can try it out again :)

@hyochan
Copy link
Member

hyochan commented Nov 16, 2018

Fantastic!

@hyochan hyochan merged commit 5b73cfa into dooboolab-community:master Nov 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants