Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check if onDayLongPressed is not null before call #240

Merged
merged 3 commits into from
Oct 12, 2020
Merged

Check if onDayLongPressed is not null before call #240

merged 3 commits into from
Oct 12, 2020

Conversation

RodolfoSilva
Copy link
Contributor

Today if the onDayLongPressed is not provided is raised an error when the user press for a long time a day button.

The workaround to solve this is pass a empty function:

onDayLongPressed: (DateTime date) {},

hyochan
hyochan requested changes Oct 12, 2020
View reviewed changes
Copy link
Member

@hyochan hyochan left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you kindly check tests failing? I think some widget is being null with if statement.

@RodolfoSilva
Copy link
Contributor Author

Could you kindly check tests failing? I think some widget is being null with if statement.

Done! Thanks @hyochan

hyochan
hyochan approved these changes Oct 12, 2020
View reviewed changes
Copy link
Member

@hyochan hyochan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work 💯

Thank you for your contribution!

@hyochan hyochan merged commit 4b67d51 into dooboolab-community:master Oct 12, 2020
@RodolfoSilva RodolfoSilva deleted the patch-1 branch October 12, 2020 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hyochan hyochan hyochan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@RodolfoSilva @hyochan