Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #79 and #80 #83

Merged
merged 1 commit into from Mar 10, 2019
Merged

fix #79 and #80 #83

merged 1 commit into from Mar 10, 2019

Conversation

edTheGuy00
Copy link
Member

@edTheGuy00 edTheGuy00 commented Mar 9, 2019 •
edited

I just reused the old code to fix issues people are having, I'll take a look more in detail when I have time.

this fixes both #79 and #80

@hyochan hyochan self-requested a review March 9, 2019 09:48
hyochan
hyochan approved these changes Mar 10, 2019
View reviewed changes
Copy link
Member

@hyochan hyochan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your attention!! 🙏
I can see some improvement in the code but I'll just merge this and release this for other's convenience.

@hyochan hyochan merged commit b244fcb into dooboolab-community:master Mar 10, 2019
@hyochan hyochan added the bugfix Fixed bug label Apr 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hyochan hyochan hyochan approved these changes

Assignees
No one assigned
Labels
bugfix Fixed bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@edTheGuy00 @hyochan