Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor java to kotlin, add showInAppMessageAndroid #365

Merged
merged 13 commits into from
Jun 4, 2022
Merged

Refactor java to kotlin, add showInAppMessageAndroid #365

merged 13 commits into from
Jun 4, 2022

Conversation

offline-first
Copy link
Contributor

@offline-first offline-first commented May 21, 2022

-Refactor java to kotlin
-Improve android implementation
-Update Billing library to 4.1.0
-Add support for in app messages on android (Play Store)

Please turn codecov off for this PR

@codecov
Copy link

codecov bot commented May 21, 2022

Codecov Report

Merging #365 (e2c41a0) into main (0c7baba) will decrease coverage by 3.56%.
The diff coverage is 11.36%.

@@            Coverage Diff             @@
##             main     #365      +/-   ##
==========================================
- Coverage   45.74%   42.18%   -3.57%     
==========================================
  Files           3        4       +1     
  Lines         435      467      +32     
==========================================
- Hits          199      197       -2     
- Misses        236      270      +34     
Impacted Files Coverage Δ
lib/modules.dart 31.76% <0.00%> (ø)
lib/flutter_inapp_purchase.dart 46.95% <9.75%> (-7.08%) ⬇️
lib/Store.dart 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c7baba...e2c41a0. Read the comment docs.

@soarescaique
Copy link

This PR seems to fix Issue #363 . Got no errors testing.

@hyochan
Copy link
Member

hyochan commented Jun 2, 2022

Thanks for reviewing this. Since these are big changes I hope more people to spend time on this PR so that we can prevent critical regressions 🙏

@offline-first
Copy link
Contributor Author

I use this Version since one week in production without any issues! The next commits are smaller :)

@soarescaique
Copy link

I have reviewed the changes this week, and they are looking good! Just waiting for the merge to launch it to production

Copy link
Member

@hyochan hyochan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've not actually reviewed this yet.
However, there are people who want this PR to be merged so I'll give a try.

Hope it is safe.

Thanks again for the great work 🙏

@hyochan hyochan merged commit 99f92e4 into dooboolab-community:main Jun 4, 2022
SpajicM pushed a commit to SpajicM/flutter_inapp_purchase that referenced this pull request Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants