Skip to content
This repository has been archived by the owner on May 7, 2023. It is now read-only.

enh: ChannelListItem photo renders and modal uis #500

Merged
merged 3 commits into from
Oct 9, 2021

Conversation

hyochan
Copy link
Member

@hyochan hyochan commented Oct 9, 2021

Specify project

Client

Description

Fix some of the styles in [LeaverChannelModal].

Render user photos in [ChannelListItem] in a more fancy way.

Screen Shot 2021-10-09 at 5 03 02 PM

2625b7f should be applied for iOS.

Related Issues

N/A

Tests

N/A

Checklist

Before you create this PR confirms that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the [CLA].
  • Run yarn lint && yarn tsc
  • Run yarn test or yarn test -u if you need to update snapshot.
  • I am willing to follow-up on review comments in a timely manner.

@hyochan hyochan changed the title Enh/chat and modal uis enh: ChannelListItem photo renders and modal uis Oct 9, 2021
@hyochan hyochan added the 🍗 enhancement New feature or request label Oct 9, 2021
@codecov
Copy link

codecov bot commented Oct 9, 2021

Codecov Report

Merging #500 (7a2283f) into master (f8266dc) will decrease coverage by 0.32%.
The diff coverage is 45.45%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #500      +/-   ##
==========================================
- Coverage   63.84%   63.52%   -0.33%     
==========================================
  Files         113      113              
  Lines        2744     2747       +3     
  Branches      457      464       +7     
==========================================
- Hits         1752     1745       -7     
- Misses        851      858       +7     
- Partials      141      144       +3     
Impacted Files Coverage Δ
...vigations/MainStackNavigator/LeaveChannelModal.tsx 22.58% <ø> (-3.14%) ⬇️
client/src/components/uis/ChannelListItem.tsx 84.41% <45.45%> (-15.59%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8266dc...7a2283f. Read the comment docs.

@hyochan hyochan merged commit 6c67205 into master Oct 9, 2021
@hyochan hyochan deleted the enh/chat-and-modal-uis branch October 9, 2021 08:14
@hyochan hyochan restored the enh/chat-and-modal-uis branch October 9, 2021 08:14
@hyochan hyochan deleted the enh/chat-and-modal-uis branch October 9, 2021 08:14
hyochan added a commit that referenced this pull request Oct 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🍗 enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant