Skip to content
This repository has been archived by the owner on May 7, 2023. It is now read-only.

bugfix: Few regessions #542

Merged
merged 7 commits into from
Mar 30, 2022
Merged

bugfix: Few regessions #542

merged 7 commits into from
Mar 30, 2022

Conversation

hyochan
Copy link
Member

@hyochan hyochan commented Mar 30, 2022

Specify project

Both

Description

Fix regressions.

  1. singleUpload mutation.
  2. Minor error messages

Related Issues

N/A

Tests

N/A

Checklist

Before you create this PR confirms that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the [CLA].
  • Run yarn lint && yarn tsc
  • Run yarn test or yarn test -u if you need to update snapshot.
  • I am willing to follow-up on review comments in a timely manner.

@codecov
Copy link

codecov bot commented Mar 30, 2022

Codecov Report

Merging #542 (aac8cd6) into master (da34ec7) will not change coverage.
The diff coverage is 66.66%.

@@           Coverage Diff           @@
##           master     #542   +/-   ##
=======================================
  Coverage   72.04%   72.04%           
=======================================
  Files          65       65           
  Lines        1284     1284           
  Branches      149      149           
=======================================
  Hits          925      925           
  Misses        359      359           
Flag Coverage Δ
unittests 72.04% <66.66%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/src/apis/root.ts 25.74% <ø> (ø)
server/src/resolvers/Upload/mutation.ts 40.00% <ø> (ø)
server/src/utils/azure.ts 34.61% <0.00%> (ø)
server/src/utils/error.ts 80.95% <0.00%> (ø)
server/src/app.ts 97.36% <100.00%> (+0.14%) ⬆️
server/src/resolvers/User/mutation.ts 72.30% <100.00%> (-0.42%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da34ec7...aac8cd6. Read the comment docs.

@hyochan hyochan added 🛠 bugfix All kinds of bug fixes ⌚️ regression Things that worked previously labels Mar 30, 2022
@hyochan hyochan merged commit e10ad2f into master Mar 30, 2022
@hyochan hyochan deleted the bugfix/few-regressions branch March 30, 2022 06:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🛠 bugfix All kinds of bug fixes ⌚️ regression Things that worked previously
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant