Skip to content
This repository has been archived by the owner on May 7, 2023. It is now read-only.

enh: updateProfile resolver #552

Merged
merged 1 commit into from
May 23, 2022
Merged

enh: updateProfile resolver #552

merged 1 commit into from
May 23, 2022

Conversation

hyochan
Copy link
Member

@hyochan hyochan commented May 23, 2022

Specify project

server

Description

Current PR resolve uncompleted feature in #551.

Checklist

Before you create this PR confirms that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the [CLA].
  • Run yarn lint && yarn tsc
  • Run yarn test or yarn test -u if you need to update snapshot.
  • I am willing to follow-up on review comments in a timely manner.

@hyochan hyochan added 🍗 enhancement New feature or request ☁️ server labels May 23, 2022
@codecov
Copy link

codecov bot commented May 23, 2022

Codecov Report

Merging #552 (bd3898d) into main (76ab008) will increase coverage by 0.02%.
The diff coverage is 62.50%.

@@            Coverage Diff             @@
##             main     #552      +/-   ##
==========================================
+ Coverage   72.28%   72.30%   +0.02%     
==========================================
  Files          65       65              
  Lines        1288     1307      +19     
  Branches      159      160       +1     
==========================================
+ Hits          931      945      +14     
- Misses        331      335       +4     
- Partials       26       27       +1     
Flag Coverage Δ
unittests 72.30% <62.50%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/src/resolvers/User/mutation.ts 71.32% <50.00%> (-0.98%) ⬇️
server/src/models/User.ts 72.54% <100.00%> (+3.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 76ab008...bd3898d. Read the comment docs.

@hyochan hyochan merged commit 4b54596 into main May 23, 2022
@hyochan hyochan deleted the enh/updateProfile branch May 23, 2022 07:58
@hyochan hyochan mentioned this pull request May 23, 2022
5 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🍗 enhancement New feature or request ☁️ server
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant