Skip to content
This repository has been archived by the owner on May 7, 2023. It is now read-only.

Apollo integration and migration due to package updates #96

Merged
merged 18 commits into from Jan 26, 2020
Merged

Conversation

hyochan
Copy link
Member

@hyochan hyochan commented Jan 26, 2020

Description

More migration

  • styled-component v5
    • It is now necessary to use px unit in styled-components'.
  • Add expo dependant packages to ncurc.json
  • Migrate Asset in expo to expo-asset

Related Issues

#53

Tests

  • Use apollo mock provider to test graphql apis.

Checklist

Before you create this PR confirms that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the [CLA].
  • Run yarn test or yarn test -u if you need to update snapshot.
  • Run yarn lint
  • I am willing to follow-up on review comments in a timely manner.

@hyochan hyochan changed the title Intl/apollo Apollo integration and migration due to package updates Jan 26, 2020
@codecov
Copy link

codecov bot commented Jan 26, 2020

Codecov Report

Merging #96 into master will decrease coverage by 1.23%.
The diff coverage is 87%.

@@            Coverage Diff             @@
##           master      #96      +/-   ##
==========================================
- Coverage   91.41%   90.18%   -1.24%     
==========================================
  Files          36       42       +6     
  Lines        1002     1110     +108     
  Branches      113      118       +5     
==========================================
+ Hits          916     1001      +85     
- Misses         38       57      +19     
- Partials       48       52       +4

@hyochan hyochan merged commit 16f471b into master Jan 26, 2020
@hyochan hyochan deleted the intl/apollo branch January 26, 2020 14:47
@hyochan hyochan mentioned this pull request Jan 27, 2020
21 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant