Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Has developerId and accoundId when requesting purchase or subscription been removed? #1125

Closed
ammarahm-ed opened this issue Sep 23, 2020 · 1 comment
Closed

Has developerId and accoundId when requesting purchase or subscription been removed? #1125

ammarahm-ed opened this issue Sep 23, 2020 · 1 comment
Labels
❓ question Further information is requested

Comments

@ammarahm-ed
Copy link

ammarahm-ed commented Sep 23, 2020 •
edited
Loading

Version of react-native-iap 4.6.1

Version of react-native 0.63.2

Platforms you faced the error (IOS or Android or both?) Android

From the release notes of Google Billing Library v3.0:

In BillingFlowParams, renamed setAccountId() to setObfuscatedAccountId(), and documented length restriction of 64 characters and restriction disallowing Personally Identifiable Information (PII) in this field. setAccountId() has been marked as deprecated and will be removed in a future library version.

Any reason why has this been removed instead of updating it to the new changes?
@BNTR BNTR mentioned this issue Oct 5, 2020
Merged
hyochan pushed a commit that referenced this issue Oct 7, 2020
@BNTR
return ability to set 'obfuscatedAccountId' and 'obfuscatedProfileId'…
0f1a6ab 
… for android billing v3 (#1141)

Hey! I created this PR just because after I had bumped the version of lib to the new one, I noticed that the functionality of passing user id to android billing is missing. It seems that it was removed accidently and it is better to add it to fullfill API of android billing v3.
Also it seems that it related to this issue #1125
@hyochan
Copy link
Member

hyochan commented Oct 10, 2020

Resolved #1141

@hyochan hyochan closed this as completed Oct 10, 2020
@hyochan hyochan added the ❓ question Further information is requested label Oct 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
❓ question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hyochan @ammarahm-ed