New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes race condition caused by billing client dereference #1388
Fixes race condition caused by billing client dereference #1388
Conversation
This needs more work. Reading the documentation for the iap library v3, I realized that we should guard the existence of the client instead of creating a new one when needed. This was likely implemented as such catering to older versions of t he SDK |
@andresesfm Is this ready for review? |
Hi, thank you @andresesfm nice catch ! I'm stuck on Android for all the tests related to purchasing (ios pass the tests (highfive) ) ;) @hyochan Hope you can review and validate the PR as soon as possible. Thank you for your time ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated small fixes in docs.
Thanks for the contribution again 🙌
There are many tickets related to duplicate events and null pointer exceptions. They were caused by the implementation that constantly created a new listener. In this PR I:
initConnection
that could cause a race condition