docs: improve documentation 17.11.2023 #2613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cervebar
force-pushed
the
docs/update
branch
from
8495143
to
f453057
Compare
hyochan
approved these changes
Nov 19, 2023
IapExample/yarn.lock
Outdated
| @@ -7002,7 +7002,7 @@ __metadata: | |||
| jest: ^29.0.0 | |||
| lodash: 4.17.21 | |||
| metro-react-native-babel-preset: ^0.76.0 | |||
| react: 17.0.2 | |||
| react: 18.2.0 | |||
There was a problem hiding this comment.
Nice upgrade but it looks like this should be 18.0.0 based on https://react-native-community.github.io/upgrade-helper/?from=0.68.2&to=0.69.2
hyochan
changed the title
hyochan
added
📖 documentation
arthurgeron
pushed a commit
to arthurgeron/react-native-iap
that referenced
this pull request
Jan 7, 2024
## docs fixes
- improve setup of project
- remove not working scripts and urls
- I managed to get Android example app to work, but unfortunately not
the iOS, see notes bellow:
## update `IAPExample` React to `18.2.0`
- because of `TypeError: undefined is not an object (evaluating
'ReactCurrentActQueue$1.isBatchingLegacy')`
- see here: facebook/react-native#34079
## iOS exampke currently not buildable because of:
- because of obsolete pods:
```
$ yarn pods
rbenv: pod: command not found
The `pod' command exists in these Ruby versions:
2.7.4
```
- see here: facebook/react-native#38921
fixed but then build failed
```
The following build commands failed:
CompileC
/Users/babu/Library/Developer/Xcode/DerivedData/IapExample-ddzasbbwninhdjgvtldlfwsnfkwf/Build/Intermediates.noindex/Pods.build/Debug-iphonesimulator/RCT-Folly.build/Objects-normal/arm64/json.o
/Users/babu/work/powerful-medical/dev/react-native-iap/IapExample/ios/Pods/RCT-Folly/folly/json.cpp
normal arm64 c++ com.apple.compilers.llvm.clang.1_0.compiler (in target
'RCT-Folly' from project 'Pods')
(1 failure)
```
-> this needs more time and investigation, and the question is, is it worth the time? - anyway added warning for anybody trying to build it regarding this README
---------
Co-authored-by: hyochan <dooboolab@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docs fixes
improve setup of project
remove not working scripts and urls
I managed to get Android example app to work, but unfortunately not the iOS, see notes bellow:
update
IAPExampleReact to18.2.0TypeError: undefined is not an object (evaluating 'ReactCurrentActQueue$1.isBatchingLegacy')iOS exampke currently not buildable because of:
fixed but then build failed
-> this needs more time and investigation, and the question is, is it worth the time? - anyway added warning for anybody trying to build it regarding this README