Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated 'compile' gradle configuration with 'implementation' #282

Merged
merged 1 commit into from Oct 9, 2018

Conversation

mars-lan
Copy link
Contributor

@mars-lan mars-lan commented Oct 7, 2018

@hyochan
Copy link
Member

hyochan commented Oct 8, 2018

@mars-lan Thank you for your PR. However, I wouldn't change this currently since react-native has default gradle version set to 3.1.4 which is not compatible with your changes. This can be merged when react-native android gradle version is upgraded to gradle version above 4.*. I think it would take long time since recent update has been made from 2->3.

@mars-lan
Copy link
Contributor Author

mars-lan commented Oct 8, 2018

I believe this is already the case for RN 0.57?

https://github.com/react-native-community/react-native-releases/blob/master/CHANGELOG.md#057

@hyochan
Copy link
Member

hyochan commented Oct 9, 2018

@mars-lan Oh. I've missed that thank you. I will merge this!

@hyochan hyochan merged commit 5e3eaf6 into dooboolab-community:master Oct 9, 2018
@hyochan hyochan added 🍗 enhancement New feature or request 🤖 android Related to android upgrade and removed 🍗 enhancement New feature or request labels Dec 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖 android Related to android
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants