-
-
Notifications
You must be signed in to change notification settings - Fork 622
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for missing async await. #295
Conversation
@lwansbrough Hi. I need your help on this |
This removes the return value from these functions, there was nothing wrong with them before. Could this please be reverted? |
It's possible that Babel is rewriting the async function in some way that makes the Promise resolve later in the microtask scheduling queue than before, but I don't see how that could possibly affect anything 🤔 |
@LinusU Wouldn't this be fine tough?
I've just looked in the code and saw that I've already gave some updates. |
The |
@LinusU Yes. This is just another |
Revert all the async as discussed in #295.
@hyochan It looks my PR is merged. It's OK. Thanks |
@JJMoon That wasn't what I was saying. The changes you've made which you swear to god to make all the functions to |
Add missing async, await notation.
이거 안드로이드는 괜찮은 지 함 보셔요..