Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(getSubscriptions) : iOS return subs properly #654

Merged
merged 1 commit into from
Aug 21, 2019

Conversation

bang9
Copy link
Contributor

@bang9 bang9 commented Aug 20, 2019

Description

iOS getSubscriptions return subscriptions that only received ids


Problem

Code

const A = await RNIap.getSubscriptions(['01.month.subscription']);
console.log('A',A);
const B = await RNIap.getSubscriptions(['01.month.subscription','03.month.subscription']);
console.log('B',B);
const C = await RNIap.getSubscriptions(['01.month.subscription','03.month.subscription','12.month.subscription']);
console.log('C',C);
const D = await RNIap.getSubscriptions(['01.month.subscription','03.month.subscription']);
console.log('D',D);
const E = await RNIap.getSubscriptions(['01.month.subscription']);
console.log('E',E);

Expected behavior

A [{..}]
B [{..},{..}]
C [{..},{..},{..}]
D [{..},{..},]
E [{..}]

Actual behavior

A [{..}]
B [{..},{..}]
C [{..},{..},{..}]
D [{..},{..},{..}]
E [{..},{..},{..}]

Result

Before and After(Android)

image

Before(iOS)

image

After(iOS)

image

return subscriptions only received ids
@hyochan hyochan added 🍗 enhancement New feature or request 📱 iOS Related to iOS labels Aug 21, 2019
Copy link
Member

@hyochan hyochan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

@hyochan hyochan merged commit fc873e0 into dooboolab-community:master Aug 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🍗 enhancement New feature or request 📱 iOS Related to iOS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants