Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error weekdays row in italian locale #79

Closed
Valitutto opened this issue Mar 7, 2019 · 3 comments
Closed

Error weekdays row in italian locale #79

Valitutto opened this issue Mar 7, 2019 · 3 comments
Labels
help wanted Extra attention is needed

Comments

@Valitutto
Copy link
Contributor

Valitutto commented Mar 7, 2019

Version of flutter_calendar_carousel

1.3.15+3

Expected behavior

In weekday row, with 'it' locale, I should see the first day of the week on Monday

Actual behavior

I see Sunday as the first day

flutter doctor result (run flutter doctor in terminal)

Doctor summary (to see all details, run flutter doctor -v):
[√] Flutter (Channel stable, v1.2.1, on Microsoft Windows [Versione 10.0.17763.348], locale it-IT)
[!] Android toolchain - develop for Android devices (Android SDK version 28.0.3)
    ! Some Android licenses not accepted.  To resolve this, run: flutter doctor --android-licenses
[!] Android Studio (version 3.3)
    X Flutter plugin not installed; this adds Flutter specific functionality.
    X Dart plugin not installed; this adds Dart specific functionality.
[√] VS Code (version 1.31.1)
[√] Connected device (1 available)

! Doctor found issues in 2 categories.

Steps to reproduce the behavior

this is the code of CalendarCarousel

CalendarCarousel<Event>(
          locale: 'it',
          onDayPressed: (DateTime date, List<Event> events) {
            setState(() {
              _currentDate = date;
            });
          },
          height: 320.0,
          todayBorderColor: Colors.green,
          weekendTextStyle: TextStyle(
            color: Colors.red,
          ),
          thisMonthDayBorderColor: Colors.grey,
          weekFormat: false,
          markedDatesMap: _markedDateMap,
          selectedDateTime: _currentDate,
          customGridViewPhysics: NeverScrollableScrollPhysics(),
          staticSixWeekFormat: true,
          //markedDateShowIcon: true,
          //markedDateIconMaxShown: 2,
          //markedDateMoreShowTotal: false,
          // null for not showing hidden events indicator
          showHeader: false,
          markedDateIconBuilder: (event) {
            return Icon(FontAwesomeIcons.solidCircle, size: 10.0);
          },
          todayTextStyle: TextStyle(
            color: Colors.blue,
          ),
          todayButtonColor: Colors.yellow,
          selectedDayTextStyle: TextStyle(
            color: Colors.white,
          ),
          //minSelectedDate: _currentDate,
          //maxSelectedDate: _currentDate.add(Duration(days: 60)),
//      inactiveDateColor: Colors.black12,
          onCalendarChanged: (DateTime date) {
            this.setState(() => _currentMonth = DateFormat.yMMM().format(date));
          },
        ),

This is the screen for the month of March, as we see the first day of the week is marked as 'dom', abbreviation for domenica (Sunday).

immagine

@hyochan hyochan added the help wanted Extra attention is needed label Mar 7, 2019
@hyochan
Copy link
Member

hyochan commented Mar 7, 2019

@akuma06 Could you please kindly help this issue out if you are available?

@Valitutto Valitutto reopened this Mar 7, 2019
@edTheGuy00
Copy link
Member

@hyochan this was my only concern on my last PR #77 as mentioned in my comment. omitting the firstDayOfWeek variable works fine on some locales. But not all I guess

@edTheGuy00
Copy link
Member

@Valitutto this should work now
Screenshot_1552123947

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants