Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved getPurchaseHistory's speed 44% faster #68

Merged
merged 1 commit into from
Mar 12, 2019
Merged

Improved getPurchaseHistory's speed 44% faster #68

merged 1 commit into from
Mar 12, 2019

Conversation

kwmt
Copy link
Member

@kwmt kwmt commented Mar 11, 2019 •
edited
Loading

  • It took 754982 microseconds to call getPurchaseHistory before, but it was able to improve to 418823 microseconds.
  • I think the order of execution of the functions is not important so I used Future.wait.

@hyochan hyochan added the enhancement New feature or request label Mar 12, 2019
@hyochan hyochan self-requested a review March 12, 2019 08:02
hyochan
hyochan approved these changes Mar 12, 2019
View reviewed changes
Copy link
Member

@hyochan hyochan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great that you handled each asynchronously.
I didn't realize that it took this much speed downside.

@hyochan hyochan merged commit 0e21bad into dooboolab-community:master Mar 12, 2019
@kwmt
Copy link
Member Author

kwmt commented Mar 13, 2019

Thank you for your reviewing.

@kwmt kwmt deleted the fetch_histories_time_faster branch March 13, 2019 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hyochan hyochan hyochan approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kwmt @hyochan