Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update version #328

Merged
merged 1 commit into from
Jun 12, 2024
Merged

Update version #328

merged 1 commit into from
Jun 12, 2024

Conversation

brunovesar
Copy link
Contributor

No description provided.

@brunovesar brunovesar self-assigned this Jun 11, 2024
ogomezba
ogomezba approved these changes Jun 11, 2024
View reviewed changes
Copy link
Contributor

@ogomezba ogomezba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

davidmolinacano
davidmolinacano approved these changes Jun 12, 2024
View reviewed changes
Copy link
Contributor

@davidmolinacano davidmolinacano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved! But just a question (just curiosity): Why are we skipping the version 0.13.19? Is this related to the mysterious appearance of this version in Packagist?

@brunovesar
Copy link
Contributor Author

I wanted to comment this at the Sync later today,
We skipped that version, because if there is someone who installed the 0.13.19 from packagist we want them to use the 0.13.18, which is the same as the 20 because the 19 had a revert.
As now the 19 is not available in packagist I'm not sure if this is needed, we'll talk about it at the sync

@brunovesar brunovesar merged commit 5ff9321 into master Jun 12, 2024
@brunovesar brunovesar deleted the bruno/update-version branch June 12, 2024 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ogomezba ogomezba ogomezba approved these changes

@davidmolinacano davidmolinacano davidmolinacano approved these changes

Assignees

@brunovesar brunovesar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@brunovesar @ogomezba @davidmolinacano