This repository has been archived by the owner on Apr 16, 2024. It is now read-only.
feat: remove commit field from package declarations
#432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pauldub
commented
Oct 29, 2023
pauldub
commented
Oct 29, 2023
pauldub
commented
Oct 29, 2023
pauldub
commented
Oct 29, 2023
pauldub
force-pushed
the
feat-remove-packages-commit-pins
branch
from
dc43c92
to
72fcaab
Compare
pauldub
commented
Oct 29, 2023
- Remove my personal packages from the lockfile. - Enable all modules to update their packages.
The plugin will soon be rewritten, the legacy branch will help avoid breaking changes.
Wrap `mason.get_package()` call with `registry.refresh()` in order to make sure the packages are actually loaded, see: williamboman/mason.nvim#1133
pauldub
commented
Oct 29, 2023
pauldub
commented
Oct 29, 2023
NTBBloodbath
approved these changes
Oct 29, 2023
There was a problem hiding this comment.
I was really just waiting for the pinning to be removed from plugins declaration, I was definitely surprised to see some breaking changes fixes haha. Thank you very much for doing this, very appreciated! 馃挏
Now I will focus on the hotfixes of the current version before continuing with the rewrite 馃檪.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey there, this PR removes the
commitfield from package declarations as requested on Github.I updated the configuration for packages that were failing after the update. There may be more broken packages.
Let me know if this sounds good to you. 馃憢