Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove DockerFile entrypoint #19

Merged
merged 2 commits into from
Dec 3, 2021
Merged

Remove DockerFile entrypoint #19

merged 2 commits into from
Dec 3, 2021

Conversation

Kikobeats
Copy link
Contributor

In any case, the command to be used should be CMD:

In short, CMD defines default commands and/or parameters for a container. CMD is an instruction that is best to use if you need a default command which users can easily override. If a Dockerfile has multiple CMDs, it only applies the instructions from the last one.

But I don't think exposing a standalone convert makes sense in this case, since the image is adding a lot of useful binaries that can be used by the end-user. Instead, leaving the Dockerfile ready to be used by user commands.

@dooman87
Copy link
Owner

dooman87 commented Dec 2, 2021

💯 agree that CMD is the better fit.

Currently the image been pulled 957k times and I imagining we could potentially break things if change the command on the latest image.

Not having the default command could make it harder to use I would think and also magick command is the wrapper for the rest (convert, identify, etc).

I'm thinking what we can do is to update ubuntu and bullseye images to use CMD with magick command. Do you reckon it will cover?

since the image is adding a lot of useful binaries

@Kikobeats
Copy link
Contributor Author

updated to use CMD + magick

@dooman87 dooman87 merged commit a0fe176 into dooman87:master Dec 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants