Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
$DOOMDIR/init.el had to be loaded earlier, so we could read the active module list. This indirectly fixes an issue where users' literate configs weren't being tangled on 'doom sync'. Fix: #6479
- Loading branch information
Showing
1 changed file
with
6 additions
and
6 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
19ce459
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hlissner it has one significant side effect.
Let assume that someone like me would like to keep
SSH_AUTH_SOCK
insideenv
file. By following a suggestion from #2434 I had in myinit.el
lines like:Since this changes a condition always false that makes such hack uselsees. The right one after this commit is:
but it quite ugly :(
19ce459
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@catap Actually, you just need an
after!
block:That said, some warning: later next month, in preparation for moving Doom's modules into another repo, I will rename
core/core-*.el
tolisp/doom-*.el
, and all the features will be renamed fromcore-*
todoom-*
. E.g.core-cli-env
=>doom-cli-env
. Keep that in mind when that breaks.19ce459
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hlissner thanks, but it should be:
you have renamed
doom-env-whitelist
todoom-env-allow
19ce459
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just for records: after b9933e6 the code should look likes:
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
Sorry, something went wrong.