Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix: #6397
- Loading branch information
Showing
2 changed files
with
29 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -136,8 +136,32 @@ we have to clean it up ourselves." | |
ranger-hide-cursor nil)) | ||
|
||
|
||
(use-package! dirvish | ||
:when (featurep! +dirvish) | ||
:defer t | ||
:init (after! dired (dirvish-override-dired-mode)) | ||
:hook (dired-mode . dired-omit-mode) | ||
:config | ||
(setq dirvish-cache-dir (concat doom-cache-dir "dirvish/") | ||
dirvish-hide-details nil | ||
dirvish-attributes '(git-msg) | ||
dired-omit-files (concat dired-omit-files "\\|^\\..*$")) | ||
(when (featurep! +icons) | ||
(push 'all-the-icons dirvish-attributes)) | ||
(map! :map dirvish-mode-map | ||
:n "b" #'dirvish-goto-bookmark | ||
:n "z" #'dirvish-show-history | ||
:n "f" #'dirvish-file-info-menu | ||
:n "F" #'dirvish-toggle-fullscreen | ||
:n "l" #'dired-find-file | ||
:n "h" #'dired-up-directory | ||
:localleader | ||
"h" #'dired-omit-mode)) | ||
|
||
|
||
(use-package! all-the-icons-dired | ||
:when (featurep! +icons) | ||
:unless (featurep! +dirvish) | ||
:hook (dired-mode . all-the-icons-dired-mode) | ||
:config | ||
;; HACK Fixes #1929: icons break file renaming in Emacs 27+, because the icon | ||
|
@@ -160,6 +184,7 @@ we have to clean it up ourselves." | |
|
||
|
||
(use-package! dired-x | ||
:unless (featurep! +dirvish) | ||
This comment has been minimized.
Sorry, something went wrong.
This comment has been minimized.
Sorry, something went wrong.
elken
Contributor
|
||
:unless (featurep! +ranger) | ||
:hook (dired-mode . dired-omit-mode) | ||
:config | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Any reason for disabling
dired-x
when usingdirvish
?I'm asking because of an
(void-variable dired-omit-files)
issue I'm constantly getting which prevents opening any file in emacs. The error seems to be triggered by line 148 above (at least it disappears when I remove that line) and as far as I could telldired-omit-files
is defined indired-x
...FWIW I've
(unpin dirvish)
to use the latest version.