Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comments in TSX files #4431

Closed
t0ster opened this issue Dec 14, 2020 · 5 comments
Closed

Comments in TSX files #4431

t0ster opened this issue Dec 14, 2020 · 5 comments
Labels
is:bug Something isn't working as intended module:lang/web Pertains to Doom's :lang web module status:resolved Issue was addressed internally

Comments

@t0ster
Copy link

t0ster commented Dec 14, 2020

Create .tsx file, try to comment portion of code that contains tags, result will be:
// <SomeComponent />

Expected result:
{/* <SomeComponent /> */}

https://github.com/hlissner/doom-emacs/blob/49f3bc193a4984f0b5a01a71ad91bb26f643c6d8/modules/lang/web/%2Bhtml.el#L68
For now I just changed ("javascript" "jsx") to ("javascript") here. This fixes the issue.

Best regards,
Roman
@hlissner
Copy link
Member

hlissner commented Dec 14, 2020 •
edited
Loading

Now try commenting out the non-tags portion of your JSX the same way. Does it use the right delimiters?

@t0ster
Copy link
Author

t0ster commented Dec 14, 2020

Just tried, it uses //. Looks fine.

@hlissner hlissner added module:lang/web Pertains to Doom's :lang web module is:bug Something isn't working as intended status:resolved Issue was addressed internally labels Dec 14, 2020
@hlissner
Copy link
Member

As of a4392b2 this issue should be resolved. Let me know if that isn't the case and I'll reopen it. Thanks for bringing it to my attention!

@saevarb
Copy link
Contributor

saevarb commented Dec 17, 2020

I don't think this is a good fix. I frequently (i.e. during debugging) comment and uncomment parts of code, and this requires me to comment out some code, uncomment all of it and then recomment parts of it again.

github-actions bot added a commit to vlaci/nix-doom-emacs that referenced this issue Dec 18, 2020
@github-actions
niv doom-emacs: update febf960c -> 0c925641
bc0c5f4 
## Changelog for doom-emacs:
Commits: [doomemacs/doomemacs@febf960c...0c925641](doomemacs/doomemacs@febf960...0c92564)

* [`1b6b1223`](doomemacs/doomemacs@1b6b122) Bump :tools magit
* [`55e90f06`](doomemacs/doomemacs@55e90f0) Load gcmh-mode a little sooner
* [`f0a5d454`](doomemacs/doomemacs@f0a5d45) Bind useful magit-file-dispatch
* [`a3b8be52`](doomemacs/doomemacs@a3b8be5) Improve doom/help-packages
* [`96d7e50f`](doomemacs/doomemacs@96d7e50) Distinguish <C-i> from "C-i"
* [`2c646df0`](doomemacs/doomemacs@2c646df) Initialize more straight state in doom-initialize-packages
* [`863063b6`](doomemacs/doomemacs@863063b) Defer internal help & help-mode packages
* [`07db84bf`](doomemacs/doomemacs@07db84b) Don't chase symlinks
* [`3c8a2a65`](doomemacs/doomemacs@3c8a2a6) Fix envvar file encoding for Windows users
* [`2772ca8e`](doomemacs/doomemacs@2772ca8) Conditionally switch to insert mode on snippet expansion
* [`8edabbec`](doomemacs/doomemacs@8edabbe) Add kbd! alias for general-simulate-key macro
* [`d149c59d`](doomemacs/doomemacs@d149c59) Add emacs mode checks to insert mode checks
* [`10f1b804`](doomemacs/doomemacs@10f1b80) Remove extraneous newline in doom/help-packages output
* [`4281a772`](doomemacs/doomemacs@4281a77) Revise core lib docstrings for clarity
* [`1fba2ea3`](doomemacs/doomemacs@1fba2ea) Bump :emacs vc
* [`7053bfbe`](doomemacs/doomemacs@7053bfb) Add "python3" to possible names for the python binary
* [`09f35970`](doomemacs/doomemacs@09f3597) Update link for nose.el
* [`61135f53`](doomemacs/doomemacs@61135f5) Enable `smartparens' for `evil-ex'
* [`621cb60e`](doomemacs/doomemacs@621cb60) Workaround: fix goto definition on modules
* [`0d330f7a`](doomemacs/doomemacs@0d330f7) `doom/help-modules': C-u -> browse directory
* [`784acaa6`](doomemacs/doomemacs@784acaa) Set ligratures for csharp-mode
* [`d2005ab5`](doomemacs/doomemacs@d2005ab) docs/api: add cmds! & kbd! demos
* [`144714e7`](doomemacs/doomemacs@144714e) Add popup rule for flycheck error list
* [`c4a0174f`](doomemacs/doomemacs@c4a0174) ivy-read-action-format-function = ivy-hydra-read-action
* [`765b6dcf`](doomemacs/doomemacs@765b6dc) Unset unused markers
* [`89db5976`](doomemacs/doomemacs@89db597) Re-enable ivy in evil-ex completion
* [`6075e6f1`](doomemacs/doomemacs@6075e6f) Refactor initialization of package state
* [`97d8de81`](doomemacs/doomemacs@97d8de8) Remove defunct straight-fix-org setting
* [`20c873d4`](doomemacs/doomemacs@20c873d) Update flycheck on idle-change
* [`09ac5a48`](doomemacs/doomemacs@09ac5a4) Add org-export-async-debug to debug vars
* [`eea47093`](doomemacs/doomemacs@eea4709) cli: run post-script indirectly
* [`5d349657`](doomemacs/doomemacs@5d34965) Fix doomemacs/doomemacs#4421: masquerade doom/escape as keyboard-quit
* [`930524f3`](doomemacs/doomemacs@930524f) Apply spell-fu blacklist to derived modes
* [`fc955f41`](doomemacs/doomemacs@fc955f4) Don't set a default ispell-dictionary
* [`2e61fbbf`](doomemacs/doomemacs@2e61fbb) Fix doomemacs/doomemacs#4407: regression in +markdown-flyspell-word-p
* [`99a83ca1`](doomemacs/doomemacs@99a83ca) A workaround for formatting org mode
* [`9c510159`](doomemacs/doomemacs@9c51015) popup.el: consider auto-saving indirect buffers too
* [`cd37300c`](doomemacs/doomemacs@cd37300) Bump :lang rust
* [`65416ff4`](doomemacs/doomemacs@65416ff) Fix doomemacs/doomemacs#4427: ivy-read-action-format-function = ivy-read-action-format-columns
* [`084defb1`](doomemacs/doomemacs@084defb) Reset sp-pair-overlay-keymap for evil users
* [`04b29c70`](doomemacs/doomemacs@04b29c7) doom/escape: change this-command only if interactive
* [`d69d2457`](doomemacs/doomemacs@d69d245) Remove sp-escape-quotes-after-insert hack
* [`58279850`](doomemacs/doomemacs@5827985) Don't increase gc-cons-threshold in org-mode
* [`49f3bc19`](doomemacs/doomemacs@49f3bc1) Fix doomemacs/doomemacs#4430: wrong-num-of-args error on expand-region
* [`9490d42c`](doomemacs/doomemacs@9490d42) Comment revision
* [`8c397902`](doomemacs/doomemacs@8c39790) Fix doomemacs/doomemacs#4432: comp-deferred-compilation-{black,deny}-list
* [`a4392b2c`](doomemacs/doomemacs@a4392b2) Fix doomemacs/doomemacs#4431: don't use // in [JT]SX markup
* [`55c37710`](doomemacs/doomemacs@55c3771) Do not panic when xclip is not available
* [`e7696893`](doomemacs/doomemacs@e769689) ivy-read-action-function = ivy-hydra-read-action
* [`8afd8a6c`](doomemacs/doomemacs@8afd8a6) Restore user ability to toggle ivy related hydras
* [`715c7368`](doomemacs/doomemacs@715c736) Prioritize company-capf back-end in org-journal
@github-actions github-actions bot mentioned this issue Dec 18, 2020
Merged
vlaci pushed a commit to vlaci/nix-doom-emacs that referenced this issue Dec 26, 2020
@github-actions
niv doom-emacs: update febf960c -> 0c925641
17eb56a 
## Changelog for doom-emacs:
Commits: [doomemacs/doomemacs@febf960c...0c925641](doomemacs/doomemacs@febf960...0c92564)

* [`1b6b1223`](doomemacs/doomemacs@1b6b122) Bump :tools magit
* [`55e90f06`](doomemacs/doomemacs@55e90f0) Load gcmh-mode a little sooner
* [`f0a5d454`](doomemacs/doomemacs@f0a5d45) Bind useful magit-file-dispatch
* [`a3b8be52`](doomemacs/doomemacs@a3b8be5) Improve doom/help-packages
* [`96d7e50f`](doomemacs/doomemacs@96d7e50) Distinguish <C-i> from "C-i"
* [`2c646df0`](doomemacs/doomemacs@2c646df) Initialize more straight state in doom-initialize-packages
* [`863063b6`](doomemacs/doomemacs@863063b) Defer internal help & help-mode packages
* [`07db84bf`](doomemacs/doomemacs@07db84b) Don't chase symlinks
* [`3c8a2a65`](doomemacs/doomemacs@3c8a2a6) Fix envvar file encoding for Windows users
* [`2772ca8e`](doomemacs/doomemacs@2772ca8) Conditionally switch to insert mode on snippet expansion
* [`8edabbec`](doomemacs/doomemacs@8edabbe) Add kbd! alias for general-simulate-key macro
* [`d149c59d`](doomemacs/doomemacs@d149c59) Add emacs mode checks to insert mode checks
* [`10f1b804`](doomemacs/doomemacs@10f1b80) Remove extraneous newline in doom/help-packages output
* [`4281a772`](doomemacs/doomemacs@4281a77) Revise core lib docstrings for clarity
* [`1fba2ea3`](doomemacs/doomemacs@1fba2ea) Bump :emacs vc
* [`7053bfbe`](doomemacs/doomemacs@7053bfb) Add "python3" to possible names for the python binary
* [`09f35970`](doomemacs/doomemacs@09f3597) Update link for nose.el
* [`61135f53`](doomemacs/doomemacs@61135f5) Enable `smartparens' for `evil-ex'
* [`621cb60e`](doomemacs/doomemacs@621cb60) Workaround: fix goto definition on modules
* [`0d330f7a`](doomemacs/doomemacs@0d330f7) `doom/help-modules': C-u -> browse directory
* [`784acaa6`](doomemacs/doomemacs@784acaa) Set ligratures for csharp-mode
* [`d2005ab5`](doomemacs/doomemacs@d2005ab) docs/api: add cmds! & kbd! demos
* [`144714e7`](doomemacs/doomemacs@144714e) Add popup rule for flycheck error list
* [`c4a0174f`](doomemacs/doomemacs@c4a0174) ivy-read-action-format-function = ivy-hydra-read-action
* [`765b6dcf`](doomemacs/doomemacs@765b6dc) Unset unused markers
* [`89db5976`](doomemacs/doomemacs@89db597) Re-enable ivy in evil-ex completion
* [`6075e6f1`](doomemacs/doomemacs@6075e6f) Refactor initialization of package state
* [`97d8de81`](doomemacs/doomemacs@97d8de8) Remove defunct straight-fix-org setting
* [`20c873d4`](doomemacs/doomemacs@20c873d) Update flycheck on idle-change
* [`09ac5a48`](doomemacs/doomemacs@09ac5a4) Add org-export-async-debug to debug vars
* [`eea47093`](doomemacs/doomemacs@eea4709) cli: run post-script indirectly
* [`5d349657`](doomemacs/doomemacs@5d34965) Fix doomemacs/doomemacs#4421: masquerade doom/escape as keyboard-quit
* [`930524f3`](doomemacs/doomemacs@930524f) Apply spell-fu blacklist to derived modes
* [`fc955f41`](doomemacs/doomemacs@fc955f4) Don't set a default ispell-dictionary
* [`2e61fbbf`](doomemacs/doomemacs@2e61fbb) Fix doomemacs/doomemacs#4407: regression in +markdown-flyspell-word-p
* [`99a83ca1`](doomemacs/doomemacs@99a83ca) A workaround for formatting org mode
* [`9c510159`](doomemacs/doomemacs@9c51015) popup.el: consider auto-saving indirect buffers too
* [`cd37300c`](doomemacs/doomemacs@cd37300) Bump :lang rust
* [`65416ff4`](doomemacs/doomemacs@65416ff) Fix doomemacs/doomemacs#4427: ivy-read-action-format-function = ivy-read-action-format-columns
* [`084defb1`](doomemacs/doomemacs@084defb) Reset sp-pair-overlay-keymap for evil users
* [`04b29c70`](doomemacs/doomemacs@04b29c7) doom/escape: change this-command only if interactive
* [`d69d2457`](doomemacs/doomemacs@d69d245) Remove sp-escape-quotes-after-insert hack
* [`58279850`](doomemacs/doomemacs@5827985) Don't increase gc-cons-threshold in org-mode
* [`49f3bc19`](doomemacs/doomemacs@49f3bc1) Fix doomemacs/doomemacs#4430: wrong-num-of-args error on expand-region
* [`9490d42c`](doomemacs/doomemacs@9490d42) Comment revision
* [`8c397902`](doomemacs/doomemacs@8c39790) Fix doomemacs/doomemacs#4432: comp-deferred-compilation-{black,deny}-list
* [`a4392b2c`](doomemacs/doomemacs@a4392b2) Fix doomemacs/doomemacs#4431: don't use // in [JT]SX markup
* [`55c37710`](doomemacs/doomemacs@55c3771) Do not panic when xclip is not available
* [`e7696893`](doomemacs/doomemacs@e769689) ivy-read-action-function = ivy-hydra-read-action
* [`8afd8a6c`](doomemacs/doomemacs@8afd8a6) Restore user ability to toggle ivy related hydras
* [`715c7368`](doomemacs/doomemacs@715c736) Prioritize company-capf back-end in org-journal
vlaci pushed a commit to vlaci/nix-doom-emacs that referenced this issue Dec 26, 2020
@github-actions
niv doom-emacs: update febf960c -> 0c925641
7a1d3a9 
## Changelog for doom-emacs:
Commits: [doomemacs/doomemacs@febf960c...0c925641](doomemacs/doomemacs@febf960...0c92564)

* [`1b6b1223`](doomemacs/doomemacs@1b6b122) Bump :tools magit
* [`55e90f06`](doomemacs/doomemacs@55e90f0) Load gcmh-mode a little sooner
* [`f0a5d454`](doomemacs/doomemacs@f0a5d45) Bind useful magit-file-dispatch
* [`a3b8be52`](doomemacs/doomemacs@a3b8be5) Improve doom/help-packages
* [`96d7e50f`](doomemacs/doomemacs@96d7e50) Distinguish <C-i> from "C-i"
* [`2c646df0`](doomemacs/doomemacs@2c646df) Initialize more straight state in doom-initialize-packages
* [`863063b6`](doomemacs/doomemacs@863063b) Defer internal help & help-mode packages
* [`07db84bf`](doomemacs/doomemacs@07db84b) Don't chase symlinks
* [`3c8a2a65`](doomemacs/doomemacs@3c8a2a6) Fix envvar file encoding for Windows users
* [`2772ca8e`](doomemacs/doomemacs@2772ca8) Conditionally switch to insert mode on snippet expansion
* [`8edabbec`](doomemacs/doomemacs@8edabbe) Add kbd! alias for general-simulate-key macro
* [`d149c59d`](doomemacs/doomemacs@d149c59) Add emacs mode checks to insert mode checks
* [`10f1b804`](doomemacs/doomemacs@10f1b80) Remove extraneous newline in doom/help-packages output
* [`4281a772`](doomemacs/doomemacs@4281a77) Revise core lib docstrings for clarity
* [`1fba2ea3`](doomemacs/doomemacs@1fba2ea) Bump :emacs vc
* [`7053bfbe`](doomemacs/doomemacs@7053bfb) Add "python3" to possible names for the python binary
* [`09f35970`](doomemacs/doomemacs@09f3597) Update link for nose.el
* [`61135f53`](doomemacs/doomemacs@61135f5) Enable `smartparens' for `evil-ex'
* [`621cb60e`](doomemacs/doomemacs@621cb60) Workaround: fix goto definition on modules
* [`0d330f7a`](doomemacs/doomemacs@0d330f7) `doom/help-modules': C-u -> browse directory
* [`784acaa6`](doomemacs/doomemacs@784acaa) Set ligratures for csharp-mode
* [`d2005ab5`](doomemacs/doomemacs@d2005ab) docs/api: add cmds! & kbd! demos
* [`144714e7`](doomemacs/doomemacs@144714e) Add popup rule for flycheck error list
* [`c4a0174f`](doomemacs/doomemacs@c4a0174) ivy-read-action-format-function = ivy-hydra-read-action
* [`765b6dcf`](doomemacs/doomemacs@765b6dc) Unset unused markers
* [`89db5976`](doomemacs/doomemacs@89db597) Re-enable ivy in evil-ex completion
* [`6075e6f1`](doomemacs/doomemacs@6075e6f) Refactor initialization of package state
* [`97d8de81`](doomemacs/doomemacs@97d8de8) Remove defunct straight-fix-org setting
* [`20c873d4`](doomemacs/doomemacs@20c873d) Update flycheck on idle-change
* [`09ac5a48`](doomemacs/doomemacs@09ac5a4) Add org-export-async-debug to debug vars
* [`eea47093`](doomemacs/doomemacs@eea4709) cli: run post-script indirectly
* [`5d349657`](doomemacs/doomemacs@5d34965) Fix doomemacs/doomemacs#4421: masquerade doom/escape as keyboard-quit
* [`930524f3`](doomemacs/doomemacs@930524f) Apply spell-fu blacklist to derived modes
* [`fc955f41`](doomemacs/doomemacs@fc955f4) Don't set a default ispell-dictionary
* [`2e61fbbf`](doomemacs/doomemacs@2e61fbb) Fix doomemacs/doomemacs#4407: regression in +markdown-flyspell-word-p
* [`99a83ca1`](doomemacs/doomemacs@99a83ca) A workaround for formatting org mode
* [`9c510159`](doomemacs/doomemacs@9c51015) popup.el: consider auto-saving indirect buffers too
* [`cd37300c`](doomemacs/doomemacs@cd37300) Bump :lang rust
* [`65416ff4`](doomemacs/doomemacs@65416ff) Fix doomemacs/doomemacs#4427: ivy-read-action-format-function = ivy-read-action-format-columns
* [`084defb1`](doomemacs/doomemacs@084defb) Reset sp-pair-overlay-keymap for evil users
* [`04b29c70`](doomemacs/doomemacs@04b29c7) doom/escape: change this-command only if interactive
* [`d69d2457`](doomemacs/doomemacs@d69d245) Remove sp-escape-quotes-after-insert hack
* [`58279850`](doomemacs/doomemacs@5827985) Don't increase gc-cons-threshold in org-mode
* [`49f3bc19`](doomemacs/doomemacs@49f3bc1) Fix doomemacs/doomemacs#4430: wrong-num-of-args error on expand-region
* [`9490d42c`](doomemacs/doomemacs@9490d42) Comment revision
* [`8c397902`](doomemacs/doomemacs@8c39790) Fix doomemacs/doomemacs#4432: comp-deferred-compilation-{black,deny}-list
* [`a4392b2c`](doomemacs/doomemacs@a4392b2) Fix doomemacs/doomemacs#4431: don't use // in [JT]SX markup
* [`55c37710`](doomemacs/doomemacs@55c3771) Do not panic when xclip is not available
* [`e7696893`](doomemacs/doomemacs@e769689) ivy-read-action-function = ivy-hydra-read-action
* [`8afd8a6c`](doomemacs/doomemacs@8afd8a6) Restore user ability to toggle ivy related hydras
* [`715c7368`](doomemacs/doomemacs@715c736) Prioritize company-capf back-end in org-journal
vlaci pushed a commit to vlaci/nix-doom-emacs that referenced this issue Dec 26, 2020
@github-actions
niv doom-emacs: update febf960c -> 0c925641
3adb93a 
## Changelog for doom-emacs:
Commits: [doomemacs/doomemacs@febf960c...0c925641](doomemacs/doomemacs@febf960...0c92564)

* [`1b6b1223`](doomemacs/doomemacs@1b6b122) Bump :tools magit
* [`55e90f06`](doomemacs/doomemacs@55e90f0) Load gcmh-mode a little sooner
* [`f0a5d454`](doomemacs/doomemacs@f0a5d45) Bind useful magit-file-dispatch
* [`a3b8be52`](doomemacs/doomemacs@a3b8be5) Improve doom/help-packages
* [`96d7e50f`](doomemacs/doomemacs@96d7e50) Distinguish <C-i> from "C-i"
* [`2c646df0`](doomemacs/doomemacs@2c646df) Initialize more straight state in doom-initialize-packages
* [`863063b6`](doomemacs/doomemacs@863063b) Defer internal help & help-mode packages
* [`07db84bf`](doomemacs/doomemacs@07db84b) Don't chase symlinks
* [`3c8a2a65`](doomemacs/doomemacs@3c8a2a6) Fix envvar file encoding for Windows users
* [`2772ca8e`](doomemacs/doomemacs@2772ca8) Conditionally switch to insert mode on snippet expansion
* [`8edabbec`](doomemacs/doomemacs@8edabbe) Add kbd! alias for general-simulate-key macro
* [`d149c59d`](doomemacs/doomemacs@d149c59) Add emacs mode checks to insert mode checks
* [`10f1b804`](doomemacs/doomemacs@10f1b80) Remove extraneous newline in doom/help-packages output
* [`4281a772`](doomemacs/doomemacs@4281a77) Revise core lib docstrings for clarity
* [`1fba2ea3`](doomemacs/doomemacs@1fba2ea) Bump :emacs vc
* [`7053bfbe`](doomemacs/doomemacs@7053bfb) Add "python3" to possible names for the python binary
* [`09f35970`](doomemacs/doomemacs@09f3597) Update link for nose.el
* [`61135f53`](doomemacs/doomemacs@61135f5) Enable `smartparens' for `evil-ex'
* [`621cb60e`](doomemacs/doomemacs@621cb60) Workaround: fix goto definition on modules
* [`0d330f7a`](doomemacs/doomemacs@0d330f7) `doom/help-modules': C-u -> browse directory
* [`784acaa6`](doomemacs/doomemacs@784acaa) Set ligratures for csharp-mode
* [`d2005ab5`](doomemacs/doomemacs@d2005ab) docs/api: add cmds! & kbd! demos
* [`144714e7`](doomemacs/doomemacs@144714e) Add popup rule for flycheck error list
* [`c4a0174f`](doomemacs/doomemacs@c4a0174) ivy-read-action-format-function = ivy-hydra-read-action
* [`765b6dcf`](doomemacs/doomemacs@765b6dc) Unset unused markers
* [`89db5976`](doomemacs/doomemacs@89db597) Re-enable ivy in evil-ex completion
* [`6075e6f1`](doomemacs/doomemacs@6075e6f) Refactor initialization of package state
* [`97d8de81`](doomemacs/doomemacs@97d8de8) Remove defunct straight-fix-org setting
* [`20c873d4`](doomemacs/doomemacs@20c873d) Update flycheck on idle-change
* [`09ac5a48`](doomemacs/doomemacs@09ac5a4) Add org-export-async-debug to debug vars
* [`eea47093`](doomemacs/doomemacs@eea4709) cli: run post-script indirectly
* [`5d349657`](doomemacs/doomemacs@5d34965) Fix doomemacs/doomemacs#4421: masquerade doom/escape as keyboard-quit
* [`930524f3`](doomemacs/doomemacs@930524f) Apply spell-fu blacklist to derived modes
* [`fc955f41`](doomemacs/doomemacs@fc955f4) Don't set a default ispell-dictionary
* [`2e61fbbf`](doomemacs/doomemacs@2e61fbb) Fix doomemacs/doomemacs#4407: regression in +markdown-flyspell-word-p
* [`99a83ca1`](doomemacs/doomemacs@99a83ca) A workaround for formatting org mode
* [`9c510159`](doomemacs/doomemacs@9c51015) popup.el: consider auto-saving indirect buffers too
* [`cd37300c`](doomemacs/doomemacs@cd37300) Bump :lang rust
* [`65416ff4`](doomemacs/doomemacs@65416ff) Fix doomemacs/doomemacs#4427: ivy-read-action-format-function = ivy-read-action-format-columns
* [`084defb1`](doomemacs/doomemacs@084defb) Reset sp-pair-overlay-keymap for evil users
* [`04b29c70`](doomemacs/doomemacs@04b29c7) doom/escape: change this-command only if interactive
* [`d69d2457`](doomemacs/doomemacs@d69d245) Remove sp-escape-quotes-after-insert hack
* [`58279850`](doomemacs/doomemacs@5827985) Don't increase gc-cons-threshold in org-mode
* [`49f3bc19`](doomemacs/doomemacs@49f3bc1) Fix doomemacs/doomemacs#4430: wrong-num-of-args error on expand-region
* [`9490d42c`](doomemacs/doomemacs@9490d42) Comment revision
* [`8c397902`](doomemacs/doomemacs@8c39790) Fix doomemacs/doomemacs#4432: comp-deferred-compilation-{black,deny}-list
* [`a4392b2c`](doomemacs/doomemacs@a4392b2) Fix doomemacs/doomemacs#4431: don't use // in [JT]SX markup
* [`55c37710`](doomemacs/doomemacs@55c3771) Do not panic when xclip is not available
* [`e7696893`](doomemacs/doomemacs@e769689) ivy-read-action-function = ivy-hydra-read-action
* [`8afd8a6c`](doomemacs/doomemacs@8afd8a6) Restore user ability to toggle ivy related hydras
* [`715c7368`](doomemacs/doomemacs@715c736) Prioritize company-capf back-end in org-journal
vlaci pushed a commit to vlaci/nix-doom-emacs that referenced this issue Jan 16, 2021
@github-actions
niv doom-emacs: update febf960c -> 0c925641
a35adea 
## Changelog for doom-emacs:
Commits: [doomemacs/doomemacs@febf960c...0c925641](doomemacs/doomemacs@febf960...0c92564)

* [`1b6b1223`](doomemacs/doomemacs@1b6b122) Bump :tools magit
* [`55e90f06`](doomemacs/doomemacs@55e90f0) Load gcmh-mode a little sooner
* [`f0a5d454`](doomemacs/doomemacs@f0a5d45) Bind useful magit-file-dispatch
* [`a3b8be52`](doomemacs/doomemacs@a3b8be5) Improve doom/help-packages
* [`96d7e50f`](doomemacs/doomemacs@96d7e50) Distinguish <C-i> from "C-i"
* [`2c646df0`](doomemacs/doomemacs@2c646df) Initialize more straight state in doom-initialize-packages
* [`863063b6`](doomemacs/doomemacs@863063b) Defer internal help & help-mode packages
* [`07db84bf`](doomemacs/doomemacs@07db84b) Don't chase symlinks
* [`3c8a2a65`](doomemacs/doomemacs@3c8a2a6) Fix envvar file encoding for Windows users
* [`2772ca8e`](doomemacs/doomemacs@2772ca8) Conditionally switch to insert mode on snippet expansion
* [`8edabbec`](doomemacs/doomemacs@8edabbe) Add kbd! alias for general-simulate-key macro
* [`d149c59d`](doomemacs/doomemacs@d149c59) Add emacs mode checks to insert mode checks
* [`10f1b804`](doomemacs/doomemacs@10f1b80) Remove extraneous newline in doom/help-packages output
* [`4281a772`](doomemacs/doomemacs@4281a77) Revise core lib docstrings for clarity
* [`1fba2ea3`](doomemacs/doomemacs@1fba2ea) Bump :emacs vc
* [`7053bfbe`](doomemacs/doomemacs@7053bfb) Add "python3" to possible names for the python binary
* [`09f35970`](doomemacs/doomemacs@09f3597) Update link for nose.el
* [`61135f53`](doomemacs/doomemacs@61135f5) Enable `smartparens' for `evil-ex'
* [`621cb60e`](doomemacs/doomemacs@621cb60) Workaround: fix goto definition on modules
* [`0d330f7a`](doomemacs/doomemacs@0d330f7) `doom/help-modules': C-u -> browse directory
* [`784acaa6`](doomemacs/doomemacs@784acaa) Set ligratures for csharp-mode
* [`d2005ab5`](doomemacs/doomemacs@d2005ab) docs/api: add cmds! & kbd! demos
* [`144714e7`](doomemacs/doomemacs@144714e) Add popup rule for flycheck error list
* [`c4a0174f`](doomemacs/doomemacs@c4a0174) ivy-read-action-format-function = ivy-hydra-read-action
* [`765b6dcf`](doomemacs/doomemacs@765b6dc) Unset unused markers
* [`89db5976`](doomemacs/doomemacs@89db597) Re-enable ivy in evil-ex completion
* [`6075e6f1`](doomemacs/doomemacs@6075e6f) Refactor initialization of package state
* [`97d8de81`](doomemacs/doomemacs@97d8de8) Remove defunct straight-fix-org setting
* [`20c873d4`](doomemacs/doomemacs@20c873d) Update flycheck on idle-change
* [`09ac5a48`](doomemacs/doomemacs@09ac5a4) Add org-export-async-debug to debug vars
* [`eea47093`](doomemacs/doomemacs@eea4709) cli: run post-script indirectly
* [`5d349657`](doomemacs/doomemacs@5d34965) Fix doomemacs/doomemacs#4421: masquerade doom/escape as keyboard-quit
* [`930524f3`](doomemacs/doomemacs@930524f) Apply spell-fu blacklist to derived modes
* [`fc955f41`](doomemacs/doomemacs@fc955f4) Don't set a default ispell-dictionary
* [`2e61fbbf`](doomemacs/doomemacs@2e61fbb) Fix doomemacs/doomemacs#4407: regression in +markdown-flyspell-word-p
* [`99a83ca1`](doomemacs/doomemacs@99a83ca) A workaround for formatting org mode
* [`9c510159`](doomemacs/doomemacs@9c51015) popup.el: consider auto-saving indirect buffers too
* [`cd37300c`](doomemacs/doomemacs@cd37300) Bump :lang rust
* [`65416ff4`](doomemacs/doomemacs@65416ff) Fix doomemacs/doomemacs#4427: ivy-read-action-format-function = ivy-read-action-format-columns
* [`084defb1`](doomemacs/doomemacs@084defb) Reset sp-pair-overlay-keymap for evil users
* [`04b29c70`](doomemacs/doomemacs@04b29c7) doom/escape: change this-command only if interactive
* [`d69d2457`](doomemacs/doomemacs@d69d245) Remove sp-escape-quotes-after-insert hack
* [`58279850`](doomemacs/doomemacs@5827985) Don't increase gc-cons-threshold in org-mode
* [`49f3bc19`](doomemacs/doomemacs@49f3bc1) Fix doomemacs/doomemacs#4430: wrong-num-of-args error on expand-region
* [`9490d42c`](doomemacs/doomemacs@9490d42) Comment revision
* [`8c397902`](doomemacs/doomemacs@8c39790) Fix doomemacs/doomemacs#4432: comp-deferred-compilation-{black,deny}-list
* [`a4392b2c`](doomemacs/doomemacs@a4392b2) Fix doomemacs/doomemacs#4431: don't use // in [JT]SX markup
* [`55c37710`](doomemacs/doomemacs@55c3771) Do not panic when xclip is not available
* [`e7696893`](doomemacs/doomemacs@e769689) ivy-read-action-function = ivy-hydra-read-action
* [`8afd8a6c`](doomemacs/doomemacs@8afd8a6) Restore user ability to toggle ivy related hydras
* [`715c7368`](doomemacs/doomemacs@715c736) Prioritize company-capf back-end in org-journal
vlaci pushed a commit to vlaci/nix-doom-emacs that referenced this issue Jan 16, 2021
@github-actions
niv doom-emacs: update febf960c -> 0c925641
02c8b4f 
## Changelog for doom-emacs:
Commits: [doomemacs/doomemacs@febf960c...0c925641](doomemacs/doomemacs@febf960...0c92564)

* [`1b6b1223`](doomemacs/doomemacs@1b6b122) Bump :tools magit
* [`55e90f06`](doomemacs/doomemacs@55e90f0) Load gcmh-mode a little sooner
* [`f0a5d454`](doomemacs/doomemacs@f0a5d45) Bind useful magit-file-dispatch
* [`a3b8be52`](doomemacs/doomemacs@a3b8be5) Improve doom/help-packages
* [`96d7e50f`](doomemacs/doomemacs@96d7e50) Distinguish <C-i> from "C-i"
* [`2c646df0`](doomemacs/doomemacs@2c646df) Initialize more straight state in doom-initialize-packages
* [`863063b6`](doomemacs/doomemacs@863063b) Defer internal help & help-mode packages
* [`07db84bf`](doomemacs/doomemacs@07db84b) Don't chase symlinks
* [`3c8a2a65`](doomemacs/doomemacs@3c8a2a6) Fix envvar file encoding for Windows users
* [`2772ca8e`](doomemacs/doomemacs@2772ca8) Conditionally switch to insert mode on snippet expansion
* [`8edabbec`](doomemacs/doomemacs@8edabbe) Add kbd! alias for general-simulate-key macro
* [`d149c59d`](doomemacs/doomemacs@d149c59) Add emacs mode checks to insert mode checks
* [`10f1b804`](doomemacs/doomemacs@10f1b80) Remove extraneous newline in doom/help-packages output
* [`4281a772`](doomemacs/doomemacs@4281a77) Revise core lib docstrings for clarity
* [`1fba2ea3`](doomemacs/doomemacs@1fba2ea) Bump :emacs vc
* [`7053bfbe`](doomemacs/doomemacs@7053bfb) Add "python3" to possible names for the python binary
* [`09f35970`](doomemacs/doomemacs@09f3597) Update link for nose.el
* [`61135f53`](doomemacs/doomemacs@61135f5) Enable `smartparens' for `evil-ex'
* [`621cb60e`](doomemacs/doomemacs@621cb60) Workaround: fix goto definition on modules
* [`0d330f7a`](doomemacs/doomemacs@0d330f7) `doom/help-modules': C-u -> browse directory
* [`784acaa6`](doomemacs/doomemacs@784acaa) Set ligratures for csharp-mode
* [`d2005ab5`](doomemacs/doomemacs@d2005ab) docs/api: add cmds! & kbd! demos
* [`144714e7`](doomemacs/doomemacs@144714e) Add popup rule for flycheck error list
* [`c4a0174f`](doomemacs/doomemacs@c4a0174) ivy-read-action-format-function = ivy-hydra-read-action
* [`765b6dcf`](doomemacs/doomemacs@765b6dc) Unset unused markers
* [`89db5976`](doomemacs/doomemacs@89db597) Re-enable ivy in evil-ex completion
* [`6075e6f1`](doomemacs/doomemacs@6075e6f) Refactor initialization of package state
* [`97d8de81`](doomemacs/doomemacs@97d8de8) Remove defunct straight-fix-org setting
* [`20c873d4`](doomemacs/doomemacs@20c873d) Update flycheck on idle-change
* [`09ac5a48`](doomemacs/doomemacs@09ac5a4) Add org-export-async-debug to debug vars
* [`eea47093`](doomemacs/doomemacs@eea4709) cli: run post-script indirectly
* [`5d349657`](doomemacs/doomemacs@5d34965) Fix doomemacs/doomemacs#4421: masquerade doom/escape as keyboard-quit
* [`930524f3`](doomemacs/doomemacs@930524f) Apply spell-fu blacklist to derived modes
* [`fc955f41`](doomemacs/doomemacs@fc955f4) Don't set a default ispell-dictionary
* [`2e61fbbf`](doomemacs/doomemacs@2e61fbb) Fix doomemacs/doomemacs#4407: regression in +markdown-flyspell-word-p
* [`99a83ca1`](doomemacs/doomemacs@99a83ca) A workaround for formatting org mode
* [`9c510159`](doomemacs/doomemacs@9c51015) popup.el: consider auto-saving indirect buffers too
* [`cd37300c`](doomemacs/doomemacs@cd37300) Bump :lang rust
* [`65416ff4`](doomemacs/doomemacs@65416ff) Fix doomemacs/doomemacs#4427: ivy-read-action-format-function = ivy-read-action-format-columns
* [`084defb1`](doomemacs/doomemacs@084defb) Reset sp-pair-overlay-keymap for evil users
* [`04b29c70`](doomemacs/doomemacs@04b29c7) doom/escape: change this-command only if interactive
* [`d69d2457`](doomemacs/doomemacs@d69d245) Remove sp-escape-quotes-after-insert hack
* [`58279850`](doomemacs/doomemacs@5827985) Don't increase gc-cons-threshold in org-mode
* [`49f3bc19`](doomemacs/doomemacs@49f3bc1) Fix doomemacs/doomemacs#4430: wrong-num-of-args error on expand-region
* [`9490d42c`](doomemacs/doomemacs@9490d42) Comment revision
* [`8c397902`](doomemacs/doomemacs@8c39790) Fix doomemacs/doomemacs#4432: comp-deferred-compilation-{black,deny}-list
* [`a4392b2c`](doomemacs/doomemacs@a4392b2) Fix doomemacs/doomemacs#4431: don't use // in [JT]SX markup
* [`55c37710`](doomemacs/doomemacs@55c3771) Do not panic when xclip is not available
* [`e7696893`](doomemacs/doomemacs@e769689) ivy-read-action-function = ivy-hydra-read-action
* [`8afd8a6c`](doomemacs/doomemacs@8afd8a6) Restore user ability to toggle ivy related hydras
* [`715c7368`](doomemacs/doomemacs@715c736) Prioritize company-capf back-end in org-journal
@afonsoduarte
Copy link

I'm still seeing this issue. Like OP, on a .tsx file, when I comment out some JSX, I get // <Component/> instead of {/* <Component /> */}

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
is:bug Something isn't working as intended module:lang/web Pertains to Doom's :lang web module status:resolved Issue was addressed internally
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@afonsoduarte @t0ster @saevarb @hlissner