Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Many comp-* variables were renamed to native-comp-* on Emacs HEAD #4995

Closed
erik-overdahl opened this issue May 6, 2021 · 7 comments
Closed
Labels
is:update An effort to catch up with changes made elsewhere re:emacs:28 Pertains to Emacs 28.x or newer re:native-comp Relates to our native compilation process at build time status:resolved Issue was addressed internally

Comments

@erik-overdahl
Copy link

This breaks doom--comp-use-all-cores.

Several other native-comp related variables were renamed from comp-* to native-comp-* in the last day or so. See commits from May 5 and 6. But only comp-async-jobs-number seems to have been blocking me from running doom-sync.

What did you expect to happen?
Expected doom upgrade and doom sync to work

What actually happened?
(void-variable comp-async-jobs-number)

Additional details:
Here is the relevant commit

Steps to reproduce:

  1. Pull/build latest changes from emacs master
  2. Try to do anything using doom
@hlissner hlissner added is:update An effort to catch up with changes made elsewhere status:confirmed Issue was verified, or request approved. Waiting for a working solution. re:native-comp Relates to our native compilation process at build time re:emacs:28 Pertains to Emacs 28.x or newer labels May 6, 2021
@erik-overdahl
Copy link
Author

Looks like comp-eln-load-path is affected as well
https://github.com/hlissner/doom-emacs/search?q=comp-eln-load-path

@hlissner
Copy link
Member

hlissner commented May 7, 2021

To quote Andrea:

Hi all,

just to mention that as suggested in bug#48025 I've pushed a bunch of
commits to perform the following renamings:

comp-eln-load-path → native-comp-eln-load-path
comp-warning-on-missing-source -> native-comp-warning-on-missing-source
comp-native-driver-options → native-comp-driver-options
comp-async-query-on-exit → native-comp-async-query-on-exit
comp-async-report-warnings-errors -> native-comp-async-report-warnings-errors
comp-async-env-modifier-form → native-comp-async-env-modifier-form
comp-async-all-done-hook → native-comp-async-all-done-hook
comp-async-cu-done-functions → native-comp-async-cu-done-functions
comp-async-jobs-number → native-comp-async-jobs-number
comp-never-optimize-functions → native-comp-never-optimize-functions
comp-bootstrap-deny-list → native-comp-bootstrap-deny-list
comp-always-compile → native-comp-always-compile
comp-verbose -> native-comp-verbose
comp-debug -> native-comp-debug
comp-speed -> native-comp-speed
comp-limple-mode -> native-comp-limple-mode

Hopefully I'm not creating too much breakage.

Regards

Andrea

I'm aware of this issue and will address it soon.

@hlissner hlissner changed the title comp-async-jobs-number has been renamed to native-comp-async-jobs-number Many comp-* variables were renamed to native-comp-* on Emacs HEAD May 8, 2021
@hlissner
Copy link
Member

hlissner commented May 8, 2021

As of 856f8b6 this should be resolved. Let me know if that isn't the case and I'll reopen the issue. Thanks for bringing it to my attention!

@hlissner hlissner added status:resolved Issue was addressed internally and removed status:confirmed Issue was verified, or request approved. Waiting for a working solution. labels May 9, 2021
@goderich
Copy link

goderich commented May 9, 2021

Was experiencing this bug yesterday after an update. Reinstalled Doom today after the fix, and everything works! Thank you @hlissner !

@Janfel
Copy link
Contributor

Janfel commented May 11, 2021

The following changes have recently (2021-05-11) been added:

comp-deferred-compilation -> native-comp-deferred-compilation
comp-deferred-compilation-deny-list -> native-comp-deferred-compilation-deny-list

hlissner added a commit that referenced this issue May 11, 2021
Two more variables were renamed upstream.
@hlissner
Copy link
Member

hlissner commented May 11, 2021

The following changes have recently (2021-05-11) been added:

comp-deferred-compilation -> native-comp-deferred-compilation
comp-deferred-compilation-deny-list -> native-comp-deferred-compilation-deny-list

6ad4f06 adds support for these changes. Thanks for letting me know!

@Janfel

This comment has been minimized.

peterhoeg pushed a commit to peterhoeg/doomemacs that referenced this issue Aug 2, 2021
Adapting to native-comp changes on Emacs HEAD.
peterhoeg pushed a commit to peterhoeg/doomemacs that referenced this issue Aug 2, 2021
Two more variables were renamed upstream.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
is:update An effort to catch up with changes made elsewhere re:emacs:28 Pertains to Emacs 28.x or newer re:native-comp Relates to our native compilation process at build time status:resolved Issue was addressed internally
Projects
None yet
Development

No branches or pull requests

4 participants