Changed editor/format lsp feature requirement from textDocument/rangeFormatting to textDocument/formatting #5302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng to textDocument/formatting.
hlissner
added
is:feature
hlissner
approved these changes
Jul 27, 2021
|
Makes sense to me, thanks! |
5 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A lot of lsp servers don't support
textDocument/rangeFormattingbut supporttextDocument/formatting(eg:rust-analyzer). The fallback formatter has some issues (like in rust-mode it won't respect the project's cargo files). I think it's better to use lsp as the default formatter as long as the lsp server support file formating.