Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(magit): replace github-review for code-review #5846

Merged
merged 2 commits into from
Dec 15, 2021
Merged

feat(magit): replace github-review for code-review #5846

merged 2 commits into from
Dec 15, 2021

Conversation

elken
Copy link
Contributor

@elken elken commented Nov 28, 2021 •
edited

code-review is considered to be a superset of github-review, and as well
as supporting more forges (gitlab support is WIP) also better fits in
with magit.

Fix: #5812

@elken elken marked this pull request as ready for review November 28, 2021 10:15
@elken elken force-pushed the feat/code-review branch 3 times, most recently from 5450282 to b0fa641 Compare November 28, 2021 14:54
@elken
Copy link
Contributor Author

elken commented Nov 29, 2021

Discussion here on handling bindings, so the snippet might end up being removed.

@hlissner hlissner added is:feature Adds or requests new features, or extends existing ones module:tools/magit Pertains to Doom's :tools magit module labels Nov 30, 2021
@elken elken force-pushed the feat/code-review branch 2 times, most recently from 2897400 to 0c9e799 Compare December 6, 2021 14:54
@hlissner hlissner added this to the v21.12 milestone Dec 14, 2021
hlissner
hlissner requested changes Dec 14, 2021
View reviewed changes
Copy link
Member

@hlissner hlissner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late response! Could you:

  1. bump :tools magit once more (and squash it into the latest bump commit)?
  2. Move the changes to README.org to the rewrite-docs branch?

modules/tools/magit/config.el Outdated Show resolved Hide resolved
@elken
Copy link
Contributor Author

elken commented Dec 14, 2021

Sorry for the late response! Could you:

1. bump `:tools magit` once more (and squash it into the latest bump commit)?

No worries

2. Move the changes to README.org to the rewrite-docs branch?

Under another PR? Sure

elken added a commit to elken/doomemacs that referenced this pull request Dec 15, 2021
@elken
docs(magit): add docs for doomemacs#5846
52deaa6 
Ref doomemacs#5846
@elken elken mentioned this pull request Dec 15, 2021
Merged
@hlissner hlissner merged commit aec025b into doomemacs:develop Dec 15, 2021
@hlissner
Copy link
Member

Thanks again for your help!

hlissner pushed a commit that referenced this pull request Dec 15, 2021
@elken
docs(magit): add docs for #5846
a5f8d44 
Ref: #5846
@elken elken deleted the feat/code-review branch December 15, 2021 15:03
@shonfeder shonfeder mentioned this pull request Feb 28, 2022
Open
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hlissner hlissner hlissner approved these changes

Assignees
No one assigned
Labels
is:feature Adds or requests new features, or extends existing ones module:tools/magit Pertains to Doom's :tools magit module
Projects
None yet
Milestone
modules v22.04
Development

Successfully merging this pull request may close these issues.

Switch from github-review to code-review (A new package from the same dev that supersedes the old-package)
3 participants
@elken @hlissner @TahaAhmedRasheed