Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using (doom-themes-treemacs-config) also changes the faces configuration for treemacs-icons-dired-mode #388

Closed
CSRaghunandan opened this issue Feb 2, 2020 · 8 comments
Labels
is:bug Something isn't working as intended re:treemacs

Comments

@CSRaghunandan
Copy link

As the title implies, setting the doom-themes-treemacs-config also change the respective faces in dired when treemacs-iconcs-dired-mode

Can I do something to disable the faces in dired being changed? Because it looks completely off. Attached screenshot below for reference.

screenshot-2020-02-02_19-13-38

CSRaghunandan added a commit to CSRaghunandan/.emacs.d that referenced this issue Feb 2, 2020
@ema2159
Copy link
Contributor

ema2159 commented Feb 2, 2020

I don't think that's something to be fixed here. We just use Tremmacs's API to configure it's icons, and nothing more than that. The real problem here is that you're using treemacs-icons-dired, which grabs the exact same icons from treemacs and puts them in dired (hence the name). A solution would be to use another plugin like all-the-icons-dired instead (that's what I use), to display the same icons, but without the chevrons in the directory icons.

@CSRaghunandan
Copy link
Author

I don't think that's something to be fixed here. We just use Tremmacs's API to configure it's icons, and nothing more than that. The real problem here is that you're using treemacs-icons-dired, which grabs the exact same icons from treemacs and puts them in dired (hence the name). A solution would be to use another plugin like all-the-icons-dired instead (that's what I use), to display the same icons, but without the chevrons in the directory icons.

I see, so the problem is with treemacs API then? So, does this issue belong in treemacs issue tracker?

How is the performance of all-the-icons-dired when a directory has many files/folders. If it is acceptable I don't mind using it.

And, what are chevrons in the directory icons?

@ema2159
Copy link
Contributor

ema2159 commented Feb 2, 2020

I don't think that's an issue, the package just does what it's supposed to, and I think the problem really is that treemacs-icons-dired it's supposed to be used with treemacs's default theme. all-the-icons-dired works pretty well and it's easy to configure!

The chevrons are the ">" symbols at the left of the directory icons.

@CSRaghunandan
Copy link
Author

I see, I'll give all-the-icons-dired a try and see how it works.

Thanks

@CSRaghunandan
Copy link
Author

@hlissner I think I found what the problem here is.

The function doom-themes-fix-treemacs-icons-dired-mode in doom-themes-ext-treemacs is supposed to set the tab-width to 1 inside dired-buffers, but for some reason, its failing to do so and you end up the result I showed in screenshot in the first post.

For now, I'm manually setting the local variable for tab-width in dired buffers to 1 as a temporary workaround.

Hope this helps you to fix the problem.

@hlissner hlissner added is:bug Something isn't working as intended re:treemacs labels Feb 3, 2020
@hlissner
Copy link
Member

hlissner commented Feb 3, 2020

I've fixed doom-themes-fix-treemacs-icons-dired-mode in aa215ed. Let me know if that isn't the case and I'll reopen the issue. Thanks for bringing it to my attention!

@CSRaghunandan
Copy link
Author

I've fixed doom-themes-fix-treemacs-icons-dired-mode in aa215ed. Let me know if that isn't the case and I'll reopen the issue. Thanks for bringing it to my attention!

Thanks, I'll check it out and get back to you.

@CSRaghunandan
Copy link
Author

@hlissner issue is fixed after updating to the latest commit.

Thank you :)

Brettm12345 pushed a commit to Brettm12345/emacs-doom-themes that referenced this issue Feb 21, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
is:bug Something isn't working as intended re:treemacs
Projects
None yet
Development

No branches or pull requests

3 participants