Enhance Colletion page [vi] #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Agree with these changes. This seems to be more practical. For those english terms that come with vietnamese explanation, should we only show explanation the first time the term appears in a lesson? I think most reader will read from the beginning to the end of a lesson and is already familiar with the term. |
Yes and No, it depends on the context, some concepts are common in programming but some are unique in Elixir. Thus IMHO your suggestion would go well with the first. |
Thank you :X
|
@trexnix thanks much for the comments, I've updated the PR |
runlevel5
pushed a commit
that referenced
this pull request
Feb 21, 2016
Enhance Colletion page [vi]
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are many English terms that could not be 1:1 translated to Vietnamese. Most of the cases, translated terms make no senses whatsoever. Because most of Vietnamese developer uses English terms in their conversations, I don't see why we have to introduce awkward translated Vietnamese terms. I'd like to propose to keep the English word but introducing Vietnamese explanation clauses.