Incorporate Redux Router #8
Conversation
doomspork
force-pushed
the
redux-refactor
branch
from
5007f80
to
a12cae2
Compare
|
@paultannenbaum this still needs lovin' but it's working! 🎉 It loads the health checks, polls for updates, and keeps the UI up-to-date. If you wanted to run it locally let me know and I can give the run down. |
|
|
||
| export function deleteHealthCheck(id, csrf_token) { | ||
| return function(dispatch) { | ||
| request.del('/health_checks/' + id) |
There was a problem hiding this comment.
ES6 has string interpolation, so you shoudl be able to make this look like: request.del('/health_checks/${id}')
*** the string interpolation requires back ticks instead of a single quote, but I didn't know how to escape it in the markdown ***
|
Looks pretty good to me. The only part that looks like it might need to be broken up is the chart summary, but it is fine for now. We should get this merged in and then do a cleanup (add linting, do some html/css refactoring, etc.) and it will be a lot cleaner. |
|
This is still very much a work in progress, I haven't yet pushed my last few days of work. Let me finish up the auth and I'll get those changes pushed up for review + merge. |
|
Alright @paultannenbaum have at it. I'm not super concerned about trivial syntax/styleguide errors right now, let's focus on the organization and functionality. Once we have everything done and working we can come back through and polish. I'm going write up some instructions for you on how to run both Hospital and Medic. |
| else | ||
| conn | ||
| |> put_flash(:info, "Bad login.") | ||
| |> render("new.html", changeset: changeset) | ||
| |> put_status(401) |
There was a problem hiding this comment.
I'm going to DRY up this JSON error handling later.
doomspork
force-pushed
the
redux-refactor
branch
from
2f0068d
to
df7dfd7
Compare
|
@paultannenbaum instructions can be found at: https://gist.github.com/doomspork/f3f64eceab9c1ec82a14 |
|
Probably outside the scope of this PR but login persisting on page refresh doesn't seem to work. It would be cool to figure that one out. |
| Panel content | ||
| </div> | ||
| </div> | ||
| <div id="root" csrf-token="<%= get_csrf_token() %>"></div> |
There was a problem hiding this comment.
This page can be deleted.
|
Looks good to me. Do have a couple questions in regards to the router, but everything else looks great. Lets get this merged in and then do some cleanup |
|
@paultannenbaum here are the two examples I based most of this on: |
doomspork
force-pushed
the
redux-refactor
branch
from
1bce0ca
to
c1e240c
Compare
|
So I did some googling and from what I interpreted, it looks like we are both right :) The docs right now are using the react router without using action creators, but using route handling via actions is the correct approach and they are waiting on the docs to be updated. We can shelve this for now and just make it a point to refactor if you want to get this merged in. References: |
This is a WIP.