Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rubocop requirement from ~> 0.74 to ~> 1.8 #45

Merged
merged 1 commit into from Jan 24, 2021

Conversation

dependabot-preview[bot]
Copy link
Contributor

Updates the requirements on rubocop to permit the latest version.

Release notes

Sourced from rubocop's releases.

RuboCop 1.8

New features

Bug fixes

  • #9298: Fix an incorrect auto-correct for Lint/RedundantCopDisableDirective when there is a blank line before inline comment. (@koic)
  • #9233: Fix Style/SoleNestedConditional copying non-relevant comments during auto-correction. (@Darhazer)
  • #9312: Fix Layout/FirstHashElementLineBreak to apply to multi-line hashes with only a single element. (@muirdm)
  • #9316: Fix Style/EmptyLiteral registering wrong offense when using a numbered block for Hash.new, i.e. Hash.new { _1[_2] = [] }. (@agargiulo)
  • #9308: Fix an error for Layout/EmptyLineBetweenDefs when using endless class method. (@koic)
  • #9314: Fix an incorrect auto-correct for Style/RedundantReturn when multiple return values have a parenthesized return value. (@koic)
  • #9335: Fix an incorrect auto-correct for EnforcedStyle: require_parentheses of Style/MethodCallWithArgsParentheses with Style/NestedParenthesizedCalls. (@koic)
  • #9290: Fix a false positive for Layout/SpaceBeforeBrackets when using array literal method argument. (@koic)
  • #9333: Fix an error for Style/IfInsideElse when using a modifier if nested inside an else after elsif. (@koic)
  • #9303: Fix an incorrect auto-correct for Style/RaiseArgs with EnforcedStyle: compact when using exception instantiation argument. (@koic)

Changes

  • #9300: Make Lint/NonDeterministicRequireOrder not to register offense when using Ruby 3.0 or higher. (@koic)
  • #9320: Support unicode-display_width v2. (@dduugg)
  • #9288: Require Parser 3.0.0.0 or higher. (@koic)
  • #9337: Add AllowedIdentifiers to Naming/VariableName. (@dvandersluis)
  • #9295: Update Style/SingleLineMethods to correct to an endless method definition if they are allowed. (@dvandersluis)
  • #9331: Mark Style/MutableConstant as unsafe. (@koic)
Changelog

Sourced from rubocop's changelog.

1.8.0 (2021-01-07)

New features

Bug fixes

  • #9298: Fix an incorrect auto-correct for Lint/RedundantCopDisableDirective when there is a blank line before inline comment. ([@koic][])
  • #9233: Fix Style/SoleNestedConditional copying non-relevant comments during auto-correction. ([@Darhazer][])
  • #9312: Fix Layout/FirstHashElementLineBreak to apply to multi-line hashes with only a single element. ([@muirdm][])
  • #9316: Fix Style/EmptyLiteral registering wrong offense when using a numbered block for Hash.new, i.e. Hash.new { _1[_2] = [] }. ([@agargiulo][])
  • #9308: Fix an error for Layout/EmptyLineBetweenDefs when using endless class method. ([@koic][])
  • #9314: Fix an incorrect auto-correct for Style/RedundantReturn when multiple return values have a parenthesized return value. ([@koic][])
  • #9335: Fix an incorrect auto-correct for EnforcedStyle: require_parentheses of Style/MethodCallWithArgsParentheses with Style/NestedParenthesizedCalls. ([@koic][])
  • #9290: Fix a false positive for Layout/SpaceBeforeBrackets when using array literal method argument. ([@koic][])
  • #9333: Fix an error for Style/IfInsideElse when using a modifier if nested inside an else after elsif. ([@koic][])
  • #9303: Fix an incorrect auto-correct for Style/RaiseArgs with EnforcedStyle: compact when using exception instantiation argument. ([@koic][])

Changes

  • #9300: Make Lint/NonDeterministicRequireOrder not to register offense when using Ruby 3.0 or higher. ([@koic][])
  • #9320: Support unicode-display_width v2. ([@dduugg][])
  • #9288: Require Parser 3.0.0.0 or higher. ([@koic][])
  • #9337: Add AllowedIdentifiers to Naming/VariableName. ([@dvandersluis][])
  • #9295: Update Style/SingleLineMethods to correct to an endless method definition if they are allowed. ([@dvandersluis][])
  • #9331: Mark Style/MutableConstant as unsafe. ([@koic][])

1.7.0 (2020-12-25)

New features

  • #9260: Support auto-correction for Style/MultilineMethodSignature. ([@koic][])
  • #9282: Make Style/RedundantFreeze and Style/MutableConstant cops aware of frozen regexp and range literals when using Ruby 3.0. ([@koic][])
  • #9223: Add new Lint/AmbiguousAssignment cop. ([@fatkodima][])
  • #9243: Support auto-correction for Style/CommentedKeyword. ([@koic][])
  • #9283: Add new Style/HashExcept cop. ([@koic][])
  • #9231: Add new Layout/SpaceBeforeBrackets cop. ([@koic][])

Bug fixes

  • #9232: Fix Style/SymbolProc registering wrong offense when using a symbol numbered block argument greater than 1, i.e. [[1, 2]].map { _2.succ }. ([@tdeo][])
  • #9274: Fix error in Metrics/ClassLength when the class only contains comments. ([@dvandersluis][])
  • #9213: Fix a false positive for Style/RedanduntFreeze when using Array#*. ([@koic][])
  • #9279: Add support for endless methods to Style/MethodCallWithArgsParentheses. ([@dvandersluis][])
  • #9245: Fix Lint/AmbiguousRegexpLiteral when given a match_with_lvasgn node. ([@dvandersluis][])
  • #9276: Add support for endless methods to Style/SingleLineMethods. ([@dvandersluis][])
Commits
  • 0af1a84 Cut 1.8
  • 0073a14 Update Changelog
  • a2d7e0a Improve handling of comments in ClassMethodsDefinition autocorrection
  • 3fea162 [Fix #9233] Improve handling of comments in SoleNestedConditional autocorrection
  • 9eb5daf Update Style/SingleLineMethods to correct to an endless method definition i...
  • 1063b4e [Fix #9337] Add AllowedIdentifiers to Naming/VariableName.
  • b734f24 Use IRB instead of Pry
  • 653df19 [Fix #9335] Fix an incorrect auto-correct for NestedParenthesizedCalls
  • e2718b4 [Fix #9333] Fix an error for Style/IfInsideElse
  • c0d28ef Add new Lint/DeprecatedConstants cop
  • Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

  • Update frequency (including time of day and day of week)
  • Pull request limits (per update run and/or open at any time)
  • Automerge options (never/patch/minor, and dev/runtime dependencies)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

Updates the requirements on [rubocop](https://github.com/rubocop-hq/rubocop) to permit the latest version.
- [Release notes](https://github.com/rubocop-hq/rubocop/releases)
- [Changelog](https://github.com/rubocop-hq/rubocop/blob/master/CHANGELOG.md)
- [Commits](rubocop/rubocop@v0.74.0...v1.8.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
@dependabot-preview dependabot-preview bot added the dependencies Pull requests that update a dependency file label Jan 8, 2021
@coveralls
Copy link

coveralls commented Jan 8, 2021

Pull Request Test Coverage Report for Build 125

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 97.288%

Totals Coverage Status
Change from base Build 109: 0.0%
Covered Lines: 287
Relevant Lines: 295

💛 - Coveralls

@nbulaj nbulaj merged commit 93fc50b into master Jan 24, 2021
@dependabot-preview dependabot-preview bot deleted the dependabot/bundler/rubocop-tw-1.8 branch January 24, 2021 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants