Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update jwt requirement from ~> 2.1 to ~> 2.2 #47

Closed
wants to merge 1 commit into from
Closed

Update jwt requirement from ~> 2.1 to ~> 2.2 #47

wants to merge 1 commit into from

Conversation

leeh
Copy link

@leeh leeh commented Feb 25, 2021

Update to most recent JWT library version.

@coveralls
Copy link

coveralls commented Feb 25, 2021

Pull Request Test Coverage Report for Build 130

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 97.288%

Totals Coverage Status
Change from base Build 129: 0.0%
Covered Lines: 287
Relevant Lines: 295

💛 - Coveralls

@nbulaj
Copy link
Member

nbulaj commented Mar 14, 2021

Hi @leeh . What is the reason to increase version dependency? Is there any security issues with lower version?

@felixyz
Copy link

felixyz commented Feb 21, 2022

@nbulaj Needed to resolve this issue: nhosoya/omniauth-apple#53

@nbulaj
Copy link
Member

nbulaj commented Feb 21, 2022

But any higher version of jwt could be used with current dependency without issues @felixyz , no? 🤔 The gem is used to encode the data, not decode. Sorry if I missing something

@felixyz
Copy link

felixyz commented Feb 21, 2022

@nbulaj Sorry haven't sorted out the details, but:

> bundle update jwt
Fetching gem metadata from https://rubygems.org/.........
Fetching gem metadata from https://rubygems.org/.
Resolving dependencies...
Bundler could not find compatible versions for gem "jwt":
  In Gemfile:
    jwt (~> 2.2.3)

    doorkeeper-jwt (~> 0.3.0) was resolved to 0.3.0, which depends on
      jwt (~> 2.1.0, >= 2.1.0)

It's the ~> 2.1.0 which conflicts.

@nbulaj
Copy link
Member

nbulaj commented Feb 23, 2022

Oh I see! Thanks
Let me do the fix

@nbulaj
Copy link
Member

nbulaj commented Feb 23, 2022

Done and released as 0.4.1
Thanks @leeh @felixyz 🎉

@felixyz
Copy link

felixyz commented Feb 23, 2022

🎉 Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants