Prevent 500 when required parameters are not present #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- the line would fail because no client was available - No client was available because no client was included in the params - Instead of a 500 error occurring for a request that was malformed, a 4xx error should be returned instead - This fix ensures that such an error is returned Co-authored-by: Boo Chalhoub <ichalhoub@mavenlink.com>
|
See #79 |
urnf
reviewed
Jul 26, 2019
| @@ -8,6 +8,7 @@ def authenticate_resource_owner! | |||
| super.tap do |owner| | |||
| next unless controller_path == Doorkeeper::Rails::Routes.mapping[:authorizations][:controllers] && | |||
| action_name == 'new' | |||
| raise Errors::OpenidConnectError unless pre_auth.valid? | |||
There was a problem hiding this comment.
This will still fail on line 37 if we're missing a redirect_uri in our error_response
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the
pre_authobject is getting inspected inauthenticate_resource_owner!, before Doorkeeper validates it. If the required OAuth params are not present, it will currently blow up withundefined method application for nil. Our pull request ensures a401error is returned rather than a500error for this bit.Solves #78
This appears to be related to #71.