Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove translation not in use: invalid_resource_owner #1019

Merged
merged 1 commit into from Jan 29, 2018
Merged

Remove translation not in use: invalid_resource_owner #1019

merged 1 commit into from Jan 29, 2018

Conversation

baxang
Copy link
Contributor

@baxang baxang commented Jan 22, 2018

The key was removed from use in #843 (discussed in #771 and formerly #444) and I think it is better removed to prevent confusion.

@nbulaj
Copy link
Member

nbulaj commented Jan 26, 2018

Hi @baxang . Can you please add a note to NEWS.md (see CONTRIBUTING section in order how to format it) and squash commits to one? Thanks

@nbulaj nbulaj self-assigned this Jan 27, 2018
@baxang
Copy link
Contributor Author

baxang commented Jan 29, 2018

Hi @nbulaj, I've updated NEWS.md and squashed commits too. Also rebased onto current master branch.

@nbulaj nbulaj merged commit 77f46b7 into doorkeeper-gem:master Jan 29, 2018
@nbulaj
Copy link
Member

nbulaj commented Jan 29, 2018

Got it. Thanks @baxang!

@baxang baxang deleted the remove-unused-translation-invalid_resource_owner branch January 29, 2018 10:33
@baxang
Copy link
Contributor Author

baxang commented Jan 29, 2018

I thank you @nbulaj. Looking forward to a new release!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants