Bug: able to obtain a token with default scopes even if they are not present in the application scopes when using client credentials #1558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ll return a token with the default scope even if the application scope does NOT include it.
houndci-bot
reviewed
Feb 21, 2022
|
not sure how to re-trigger houndci. I addressed the issues found in my second commit. |
enrico
changed the title
|
Thanks @enrico |
|
@nbulaj you're welcome! |
jsugarman
added a commit
to ministryofjustice/laa-hmrc-interface-service-api
that referenced
this pull request
Sep 15, 2022
The bump to 5.6.0 broke our hmrc submissions following the change in [pull request 1558](doorkeeper-gem/doorkeeper#1558) which are documented in the CHANGELOG as: [#1558] Fixed bug: able to obtain a token with default scopes even if they are not present in the application scopes when using client credentials.
jsugarman
added a commit
to ministryofjustice/laa-hmrc-interface-service-api
that referenced
this pull request
Sep 15, 2022
The bump to 5.6.0 broke our hmrc submissions following the change in [pull request 1558](doorkeeper-gem/doorkeeper#1558) which are documented in the CHANGELOG as: [#1558] Fixed bug: able to obtain a token with default scopes even if they are not present in the application scopes when using client credentials.
jsugarman
added a commit
to ministryofjustice/laa-hmrc-interface-service-api
that referenced
this pull request
Sep 15, 2022
The minor bump to 5.6.0 broke our hmrc submissions following the change in [pull request 1558](doorkeeper-gem/doorkeeper#1558) which are documented in the CHANGELOG as: [#1558] Fixed bug: able to obtain a token with default scopes even if they are not present in the application scopes when using client credentials.
jsugarman
added a commit
to ministryofjustice/laa-hmrc-interface-service-api
that referenced
this pull request
Sep 15, 2022
The minor bump to 5.6.0 broke our hmrc submissions following the change in [pull request 1558](doorkeeper-gem/doorkeeper#1558) which are documented in the CHANGELOG as: [#1558] Fixed bug: able to obtain a token with default scopes even if they are not present in the application scopes when using client credentials.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see description of issue #1557