fix: remove unnecessarily refetches application object #1599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbulaj
approved these changes
Nov 8, 2022
|
OK I wanna to release a minor update and include this one into it, so will merge and add myself |
sealabcore
reviewed
Nov 28, 2022
| @@ -28,8 +28,9 @@ def scopes | |||
|
|
|||
| def find_or_create_access_token(client, resource_owner, scopes, server) | |||
| context = Authorization::Token.build_context(client, grant_type, scopes, resource_owner) | |||
| application = client.is_a?(Doorkeeper::Application) ? client : client.application if client | |||
There was a problem hiding this comment.
Doing this breaks apps that are using Custom application classes as defined in doorkeeper.rb
application_class "MyCustomApplicationClass"And defined like so
# frozen_string_literal: true
class MyCustomApplicationClass < ApplicationRecord
include ::Doorkeeper::Orm::ActiveRecord::Mixins::Application
end
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix #1574
passed the specs too