Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop support for Rubies 2.5 and 2.6 #1622

Merged
merged 1 commit into from Jan 12, 2023
Merged

Drop support for Rubies 2.5 and 2.6 #1622

merged 1 commit into from Jan 12, 2023

Conversation

sato11
Copy link
Contributor

@sato11 sato11 commented Jan 11, 2023 •
edited

Summary

After #1618 I recognized some remaining stuff:

  • Ruby 2.5 has been untested since Drop Ruby 2.4 because of EOL #1502 (it says 2.4 but 2.5 was excluded from travis at this point)
  • Ruby 2.6 is going to be untested from now on

So I propose that we exclude these versions. How does that sound?

@sato11 sato11 force-pushed the drop-support-for-eol-versions branch from 95add76 to 9893c0e Compare January 11, 2023 10:24
@sato11 sato11 marked this pull request as ready for review January 11, 2023 10:24
nbulaj
nbulaj approved these changes Jan 12, 2023
View reviewed changes
Copy link
Member

@nbulaj nbulaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@nbulaj nbulaj merged commit a2151df into doorkeeper-gem:main Jan 12, 2023
@sato11 sato11 deleted the drop-support-for-eol-versions branch January 12, 2023 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nbulaj nbulaj nbulaj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sato11 @nbulaj