Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass client instead of grant.application to find_or_create_access_token #1667

Merged
merged 3 commits into from Sep 19, 2023
Merged

Pass client instead of grant.application to find_or_create_access_token #1667

merged 3 commits into from Sep 19, 2023

Conversation

giovannelli
Copy link
Contributor

Closes #1666

nbulaj
nbulaj approved these changes Aug 31, 2023
View reviewed changes
Copy link
Member

@nbulaj nbulaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sounds correct to me 👍

Can we also add a changelog entry?

@nbulaj nbulaj added this to the 5.6.7 milestone Aug 31, 2023
@nbulaj nbulaj merged commit 01321c7 into doorkeeper-gem:main Sep 19, 2023
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nbulaj nbulaj nbulaj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.6.7
Development

Successfully merging this pull request may close these issues.

Issue with defining application_class in Doorkeeper config causing NoMethodError
3 participants
@giovannelli @nbulaj @clgiovannelli