added ActionController::Instrumentation in TokensController #293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,6 +1,8 @@ | |||
| module Doorkeeper | |||
| class TokensController < ActionController::Metal | |||
| include Helpers::Controller | |||
| include ActionController::RackDelegation | |||
There was a problem hiding this comment.
what is RackDelegation for? I would have thought ::Instrumentation would manage its dependencies. maybe using it for something else?
There was a problem hiding this comment.
I thought so too, but it didn't work without it.
I had trouble finding what was the problem, so I've added all modules from ActionController::Base and removed one by one, until I found the missing one.
There was a problem hiding this comment.
According to http://api.rubyonrails.org/classes/ActionController/Instrumentation.html it's an "Included Module" from Instrumentation, didn't check further. Thank you both for your help!
tute
added a commit
that referenced
this pull request
Oct 6, 2013
…tion added ActionController::Instrumentation in TokensController
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.