Rename user factory to doorkeeper_testing_user #871
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Developers of Rails applications love to include the factories from the doorkeeper gem into their applications because the factories make it easy to do feature testing of the API, stubbing out the relevant doorkeeper models. However, there is a name conflict on the user factory (which is a global namespace), so that developers cannot include `<path_to_doorkeeper>/spec/factories.rb` if their own factories.rb includes a :user factory (which most do). This change simply renames the internal factory (which is only used in 1 test anyways) to a scoped name that is much less likely to conflict. It does not change which class the factory is modeled off of (still the user.rb in the dummy spec app).
|
related to #55 |
|
Merged into master. Thank you! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Developers of Rails applications love to include the factories from the doorkeeper gem into their applications because the factories make it easy to do feature testing of the API, stubbing out the relevant doorkeeper models.
However, there is a name conflict on the user factory (which is a global namespace), so that developers cannot include
<path_to_doorkeeper>/spec/factories.rbif their own factories.rb includes a:userfactory (which most do).This change simply renames the internal factory (which is only used in 1 test anyways) to a scoped name that is much less likely to conflict. It does not change which class the factory is modeled off of (still the user.rb in the dummy spec app).