-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor #19
Open
tunnckoCore
wants to merge
18
commits into
doowb:master
Choose a base branch
from
tunnckoCore:refactor
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Refactor #19
Changes from 1 commit
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
9808df3
chore: cleanup
a7d2744
fix: add source, update deps & eslint config
a3511bc
fix: start tests
7d3efbe
fix: make it work for hbs and helpers context
869210a
fix: more ensurance cases
55c8546
fix: hbs tests
11a9b49
fix: start updating the regular tests
46c1bd6
fix: rename .helper -> .set
b8e4132
fix: 100% coverage
9b09577
rewritten again, a lot better
ed58a0c
start updating tests
c681b8e
fix examples/refactor.js, add helper returning a promise
a1bdc53
fix: finally working with both lodash and hbs
d94cca1
fix: add .hasAsyncId method and so better args resolving
7c782bd
fix: adapt rest of the tests
7a7536a
fix: back to 100% coverage
377205f
fix: drop support for Node < 8
fda97ea
fix: appveyor test on node >= 8
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Absolutely intentionally using a recursive call to
func()
instead to thethis.resolveId
orthis.resolveIds
, because when the passed value is actual value and not an async id, then it (resolveId method) will throw.