Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updates per issues #29

Merged
merged 8 commits into from Jan 25, 2018
Merged

updates per issues #29

merged 8 commits into from Jan 25, 2018

Conversation

doowb
Copy link
Owner

@doowb doowb commented Sep 12, 2017

This PR addresses a few issues:

  • unused properties #24 removing unused properties
  • name in task event is undefined #21 and emit task and build #20 refactors events so only 3 events are emitted:
    • task when a task is registered, starting, and finished. Task emitted with status populated.
    • build when a build is starting and finished. Build has runtime information and status populated.
    • error on errors with additional .app, .task, and .build properties

TODO: before merging finish up a couple other issues:

 - remove this._appname
 - remove this.buildHistory
 - update tests
 - closes #24
 - emit 'task' when registering, starting, and finishing tasks
 - emit 'build' when starting and finishing builds
 - emit 'error' on task and build errors
 - closes #21
@doowb doowb merged commit 26560d8 into master Jan 25, 2018
@jonschlinkert
Copy link
Collaborator

awesome! thanks!!!

@doowb
Copy link
Owner Author

doowb commented Jan 25, 2018

np... I'm updating some docs and will have this published in a little bit. Going to publish as 1.0.0 since there were breaking changes.

@doowb doowb deleted the events branch April 25, 2018 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants