Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix requests UTF8 encoding for special characters #12

Merged
merged 5 commits into from
Mar 26, 2021

Conversation

bumbummen99
Copy link
Contributor

Add workaround to encode URL as UTF-8 fixing URLs that include special characters such as umlauts like ö

Source: node-fetch/node-fetch#245

Add workaround to encode URL as UTF-8 fixing URLs that include special characters such as umlauts like `ö`

Source: node-fetch/node-fetch#245
@bumbummen99
Copy link
Contributor Author

Checks fail due to CC_TEST_REPORTER_ID not being available to forks.

@dopecodez
Copy link
Owner

Ah, thanks for pointing that out @bumbummen99 .

I read through the reasons for this https://github.community/t/make-secrets-available-to-builds-of-forks/16166 and it doesn't look like there's gonna be a solution from github anytime soon. I'll have to make the secret public or do any of the workarounds mentioned in the ticket. I'll also check out how other open source libraries which have moved to github actions are handling the problem.

source/request.ts Outdated Show resolved Hide resolved
source/request.ts Outdated Show resolved Hide resolved
@dopecodez
Copy link
Owner

Other than that, the changes look good, I tested out your fork and its working fine. Thanks for the PR, @bumbummen99 🏅

source/request.ts Outdated Show resolved Hide resolved
@dopecodez dopecodez merged commit 8fe2d3a into dopecodez:master Mar 26, 2021
@dopecodez dopecodez mentioned this pull request Mar 26, 2021
@bumbummen99
Copy link
Contributor Author

Other than that, the changes look good, I tested out your fork and its working fine. Thanks for the PR, @bumbummen99

Can we please get a new release tag including the fix? 😃

@dopecodez
Copy link
Owner

Apologies @bumbummen99. I was planning on releasing it later but got caught up with work. The release is published here: https://github.com/dopecodez/Wikipedia/releases/tag/v1.0.5 and should be available in the npm store.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants