-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix requests UTF8 encoding for special characters #12
Conversation
Add workaround to encode URL as UTF-8 fixing URLs that include special characters such as umlauts like `ö` Source: node-fetch/node-fetch#245
Checks fail due to |
Ah, thanks for pointing that out @bumbummen99 . I read through the reasons for this https://github.community/t/make-secrets-available-to-builds-of-forks/16166 and it doesn't look like there's gonna be a solution from github anytime soon. I'll have to make the secret public or do any of the workarounds mentioned in the ticket. I'll also check out how other open source libraries which have moved to github actions are handling the problem. |
Other than that, the changes look good, I tested out your fork and its working fine. Thanks for the PR, @bumbummen99 🏅 |
Can we please get a new release tag including the fix? 😃 |
Apologies @bumbummen99. I was planning on releasing it later but got caught up with work. The release is published here: https://github.com/dopecodez/Wikipedia/releases/tag/v1.0.5 and should be available in the npm store. |
Add workaround to encode URL as UTF-8 fixing URLs that include special characters such as umlauts like
ö
Source: node-fetch/node-fetch#245