Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

to_textgrid fails for Eaf from sample file #31

Closed
xrotwang opened this issue Feb 3, 2021 · 3 comments · Fixed by #39
Closed

to_textgrid fails for Eaf from sample file #31

xrotwang opened this issue Feb 3, 2021 · 3 comments · Fixed by #39
Milestone

Comments

@xrotwang
Copy link
Collaborator

xrotwang commented Feb 3, 2021

I noticed the last release of this package on pypi is from 2016. While it still installs (e.g. under py37), the test suite does not pass - and I noticed bugs (e.g. under py3.5), like

>>> e = pympi.Eaf('test/sample_2.7.eaf')
>>> tg = e.to_textgrid()
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/home/forkel/venvs/tpympi/lib/python3.5/site-packages/pympi/Elan.py", line 1328, in to_textgrid
    _, end = self.get_full_time_interval()
  File "/home/forkel/venvs/tpympi/lib/python3.5/site-packages/pympi/Elan.py", line 650, in get_full_time_interval
    (min(self.timeslots.values()), max(self.timeslots.values()))
TypeError: unorderable types: int() < NoneType()

So it doesn't look like it is fully supported under py3 - yet?

@dopefishh
Copy link
Owner

Python2 and python3 were both supported at the time but it may be the case that some backwards incompatible changes have been added to later versions of python3 that broke support for one or the other.

I would be glad to have things polished and make a new release. It may even be worthwhile stop supporting python2 since it becomes increasingly more difficult to write code that works both on python3 and python2 and python2 is EOL anyway.

@xrotwang
Copy link
Collaborator Author

xrotwang commented Feb 3, 2021

I dropped py2 support for all of my packages a couple of months ago - and haven't heard complaints :)
Let me know if you'd like help with any of that.

@dopefishh dopefishh added this to the Release 1.7 milestone Feb 3, 2021
@dopefishh
Copy link
Owner

Thanks, feel free to pick up on any issue tagged with the Release 1.7 milestone. If they are fixed I propose to upload a new version of the package to pypi

@xrotwang xrotwang changed the title Are there plans for a new release? to_textgrid fails for Eaf from sample file Feb 4, 2021
xrotwang added a commit that referenced this issue Feb 4, 2021
- drops py2 compat
- closes #37
- closes #31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants