Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Private GitHub Instances #100

Closed
joecharles33 opened this issue Jun 23, 2020 · 0 comments · Fixed by #102
Closed

Support Private GitHub Instances #100

joecharles33 opened this issue Jun 23, 2020 · 0 comments · Fixed by #102
Assignees
@themoosman
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Milestone
v1.2

Comments

@joecharles33
Copy link
Contributor

The pelorus project doesn't currently support private github instances.
@etsauer etsauer added the kind/feature Categorizes issue or PR as related to a new feature. label Jun 23, 2020
@etsauer etsauer added this to the v1.2 milestone Jun 23, 2020
@themoosman themoosman self-assigned this Jun 24, 2020
@themoosman themoosman mentioned this issue Jun 24, 2020
Merged
kkoller pushed a commit that referenced this issue Jun 26, 2020
@themoosman @etsauer
Updates for issue #100 (#102)
6a84ac3 
* Updates for issues #100

* Add Pylama status badge (#103)

* Change default app label to `app.kubernetes.io/name` and make it configurable (#99)

* Address issue #95, and make APP_LABEL more configurable

* Update values file for other exporters

* Exit app if required env vars aren't set

* Resolve pylama issues

* Change lib_pelorus.loader to simply pelorus

* Clean up one reference to lib_pelorus

* Update Configuration example

Co-authored-by: Eric Sauer <esauer@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@themoosman themoosman

Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Milestone
v1.2
Development

Successfully merging a pull request may close this issue.

Updates for issue #100
3 participants
@themoosman @etsauer @joecharles33