Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pelorus Grafana dashboard does not work if long term storage isn't used #89

Closed
themoosman opened this issue Jun 10, 2020 · 1 comment · Fixed by #94
Closed

Pelorus Grafana dashboard does not work if long term storage isn't used #89

themoosman opened this issue Jun 10, 2020 · 1 comment · Fixed by #94
Labels
kind/bug Categorizes issue or PR as related to a bug.
Milestone

Comments

@themoosman
Copy link
Collaborator

Running pelorus without long term storage breaks Grafana. This is because when long term storage isn't run, the service https://thanos-pelorus.pelorus.svc:9092 isn't created. However, the Grafana dashboard still points to that service.

@themoosman themoosman added the kind/bug Categorizes issue or PR as related to a bug. label Jun 10, 2020
@etsauer
Copy link
Collaborator

etsauer commented Jun 10, 2020

Looks like when we merged the thanos work we missed that the grafana datasource for prometheus got replaced with this one:

https://github.com/redhat-cop/pelorus/blob/master/charts/deploy/templates/grafana-thanos-datasource.yaml

We'll need to handle the cases more intelligently.

@etsauer etsauer added this to To do in Pelorus Roadmap via automation Jun 16, 2020
@etsauer etsauer added this to the v1.2 milestone Jun 16, 2020
Pelorus Roadmap automation moved this from To do to Done Jun 17, 2020
etsauer pushed a commit that referenced this issue Jun 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

2 participants