Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce datastructures from committime cleanup #1043

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

KevinMGranger
Copy link
Collaborator

I'm splitting up #720 into pieces so it's easier to review. This is an unobtrusive change, just copying over datastructures from that PR. (And unit tests for one of them).

Side note: make unit-tests gives me a bunch of ModuleNotFoundError: No module named 'exporters' errors. What gives?

Signed-off-by: Kevin M Granger <kgranger@redhat.com>
@openshift-ci
Copy link

openshift-ci bot commented Aug 5, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from kevinmgranger. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@github-actions
Copy link

github-actions bot commented Aug 5, 2023

Test images available! 🧪🚀 To test operator with them, run

operator-sdk run bundle \
quay.io/pelorus/rc-pelorus-operator-bundle:vpr1043-f4e8487 \
--namespace test-pelorus-operator

To clean up environment afterwards, run

operator-sdk cleanup pelorus-operator --namespace test-pelorus-operator



@attrs.frozen
class GitRepo:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a replace of CommitMetric right?

If so, please checks the changes here #900 so they are also applied here

And if you want, you can look into this issue #903

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not a replacement, but is part of the replacement input.

Mind if I ask a few more questions in #900?

Signed-off-by: Kevin M Granger <kgranger@redhat.com>
@github-actions
Copy link

Test images available! 🧪🚀 To test operator with them, run

operator-sdk run bundle \
quay.io/pelorus/rc-pelorus-operator-bundle:vpr1043-b5a41bc \
--namespace test-pelorus-operator

To clean up environment afterwards, run

operator-sdk cleanup pelorus-operator --namespace test-pelorus-operator

@openshift-ci
Copy link

openshift-ci bot commented Aug 23, 2023

@KevinMGranger: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/4.10-e2e-openshift 52c35fa link true /test 4.10-e2e-openshift
ci/prow/4.12-e2e-openshift 52c35fa link true /test 4.12-e2e-openshift

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants