Update OCP check script and upstream support with the prow changes #1084
Conversation
There was a problem hiding this comment.
Also need to remove old references in README.md and .github/ISSUE_TEMPLATE/bug.yml
I would also add a deprecated warning (just a comment is enough) to Makefile E2E test scenario 2 command https://github.com/dora-metrics/pelorus/blob/master/Makefile#L126
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
mpryc
force-pushed
the
prow_ocp_13_only
branch
from
1c76e0c
to
d155844
Compare
|
/unhold |
openshift-ci
bot
removed
the
do-not-merge/hold
|
/retest-required |
I left the issue list of older OCP releases. It's a bug entry and we don't force user to use X or Y version of OCP + we should allow to log against already existing deployments. I don't think we should deprecate scenario-2, we just don't run them in the periodics. |
The PROW CI jobs were updated to use only latest OCP release for their runs. The documentation and the check openshift version script needs to be changed as well. PROW PR: openshift/release#44348 Signed-off-by: Michal Pryc <mpryc@redhat.com>
mpryc
force-pushed
the
prow_ocp_13_only
branch
from
d155844
to
16cf9fa
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mateusoliveira43 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
I think the regex for PROW is working, it did not trigger for your newest commit that does not touch the files delacred in it 😄 But I think we left this there https://github.com/openshift/release/blob/master/core-services/prow/02_config/dora-metrics/pelorus/_prowconfig.yaml#L19 we should remove it right? (if you want, you can bypass branch protection and merge this PR) |
I think it's because my PR was after the above was merged, so it got old required jobs. |
|
/retest required |
|
@mpryc: The
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test 4.13-e2e-openshift |
|
@mpryc: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Merging as it previously passed checks. |
The PROW CI jobs were updated to use only latest OCP release for their runs. The documentation and the check openshift version script needs to be changed as well.
PROW PR: openshift/release#44348