Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue 88; resolve linting errors in exporters #96

Merged
merged 2 commits into from Jun 17, 2020
Merged

Fix issue 88; resolve linting errors in exporters #96

merged 2 commits into from Jun 17, 2020

Conversation

etsauer
Copy link
Collaborator

@etsauer etsauer commented Jun 17, 2020

@redhat-cop/mdt

themoosman
themoosman reviewed Jun 17, 2020
View reviewed changes
Copy link
Collaborator

@themoosman themoosman left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The lama isn't happy.

File is reading: exporters/failure/app.py
Run pycodestyle {'max_line_length': 120}
Run pyflakes {}
Run mccabe {}
exporters/committime/app.py:44:25: E124 closing bracket does not match visual indentation [pycodestyle]

themoosman
themoosman approved these changes Jun 17, 2020
View reviewed changes
Copy link
Collaborator

@themoosman themoosman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@themoosman themoosman merged commit 5057a4b into dora-metrics:master Jun 17, 2020
@etsauer etsauer linked an issue Jun 18, 2020 that may be closed by this pull request
Committime exporter failing to return any data because of one build. #88
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@themoosman themoosman themoosman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Committime exporter failing to return any data because of one build.
2 participants
@etsauer @themoosman