Adding support for Arrow List(*) for Python
#337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phil-opp
approved these changes
Aug 14, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an intermediate Pull Request in supporting more types. that makes it possible to send all basic types (i16, f32, u64...) when using python API.
The main idea is to refactor the
Metadatastruct to allow it to pass adata_typefield specifying the type. This type is then used when constructing the arrow array.This work for dora Python Node API and dora Python Operator API.
I have also added a small optimization that makes removes a round trip from the Python Operator to the Runtime if the vector is smaller than shared memory.
To test
You can check the newly updated
python-operator-examplewherenp.uint8downcasting has been removed and the type is passed through the dora event message.