Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small refactoring #342

Merged
merged 4 commits into from
Aug 29, 2023
Merged

Small refactoring #342

merged 4 commits into from
Aug 29, 2023

Conversation

haixuanTao
Copy link
Collaborator

@haixuanTao haixuanTao commented Aug 29, 2023 •
edited
Loading

Small refactoring:

  • Removing Capnproto message building
  • Fixing latest clippy warnings
  • Adding pyarrow to python dependencies to have it installed at the same time of dora-rs
  • Avoid running two times the CI by restricting the push trigger to the main branch

phil-opp
phil-opp approved these changes Aug 29, 2023
View reviewed changes
Copy link
Collaborator

@phil-opp phil-opp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@phil-opp phil-opp merged commit 0835a19 into merge-ros2-bridge Aug 29, 2023
15 of 16 checks passed
@phil-opp phil-opp deleted the small-refactoring branch August 29, 2023 15:10
@haixuanTao haixuanTao mentioned this pull request Sep 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phil-opp phil-opp phil-opp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@haixuanTao @phil-opp