Fix leak for symbolic link in exfat_lookup #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While exfat_lookup() for symbolic file, we Should not alloc memory to EXFAT_I(inode)->target since the corredspoding exfat inode info is still is in memory and EXFAT_I(inode)->target has not released yet. If we do so, memory leak would happen. Therefore we only alloc it if not null. Reviewed-by: Ethan Wu <ethanwu@synology.com> Signed-off-by: Chung-Chiang Cheng <cccheng@synology.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While exfat_lookup() for symbolic file, we Should not alloc memory
to EXFAT_I(inode)->target since the corredspoding exfat inode info
is still is in memory and EXFAT_I(inode)->target has not released
yet. If we do so, memory leak would happen. Therefore we only alloc
it if not null.
Reviewed-by: Ethan Wu ethanwu@synology.com
Signed-off-by: Chung-Chiang Cheng cccheng@synology.com